-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlBuilder regex expression removes chars outside /** **/ clauses #436
Comments
Same as #280 ? |
It's the same problem. I tested input from here and #280 with both proposed regular expressions
on http://regexstorm.net/tester tester side by side and they give similar results except for the split-list tab(regex split function?) where the expression in #280 omits some results. I'm not sure what expression is better. |
We started encountering this issue today. Guess we've been lucky before. Adding the question mark fixed it with no ill effects in our codebase.
|
This can be closed as a dup of #280. |
Fixes DapperLib#436, DapperLib#280 My editor has also normalized a few line endings to LF like 99% of the file was.
The issue is on SqlBuilder line 67:
Given the following sql input:
it deletes "INNER JOIN some join data" if where/order by clause are not present.
It can be tested online on:
http://regexstorm.net/tester
with above sqlinput and
\/\*\*.+\*\*\/
expression.If I change the expression to
/\*\*(.+?)\*\*/
seems to work fine.The text was updated successfully, but these errors were encountered: