Inconsistent return value for Insert/InsertAsync in Dapper Contrib

[martinknafve]

Is there a reason for InsertAsync returning int while Insert returns a long?

[mgravell]

Agree that is definitely inconsistent; it is a breaking change to fix,
though - we should probably set this as a "next breaking change" milestone.

On 13 July 2016 at 16:05, Martin Knafve notifications@github.com wrote:

Is there a reason for InsertAsync
https://github.com/StackExchange/dapper-dot-net/blob/master/Dapper.Contrib/SqlMapperExtensions.cs#L290
returning Task while Insert
https://github.com/StackExchange/dapper-dot-net/blob/master/Dapper.Contrib/SqlMapperExtensions.Async.cs#L124
returns a long?

[image: image]
https://cloud.githubusercontent.com/assets/71842/16807666/98a0dfd8-4919-11e6-956e-7ac4fa1f6049.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/StackExchange/dapper-dot-net/issues/559, or mute the
thread
https://github.com/notifications/unsubscribe/AABDsG8sVu002cDqM85q_52PzP45_04Tks5qVP7UgaJpZM4JLhNS
.

Regards,

Marc

[NickCraver]

I'll make sure to address this in v2, since it's a breaking change. Adding to the discussion list (link will appear below shortly).