Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /tokens:/chainName:/tokenAddress pages #38

Merged
merged 11 commits into from
Jan 6, 2024
Merged

Conversation

KillariDev
Copy link

No description provided.

@KillariDev KillariDev marked this pull request as draft January 5, 2024 10:37
@KillariDev KillariDev marked this pull request as ready for review January 5, 2024 15:27
Comment on lines +27 to 28
const UNKNOWN_TOKEN_SYMBOL = 'UNKNOWN'
const UNKNOWN_TOKEN_NAME = 'Unknown Token'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that these are both file-local, feels like they could just be inlined. Especially since they are only used in one place.

Base automatically changed from remove-api-price-querying to main January 6, 2024 13:42
@KillariDev KillariDev merged commit 5f7a905 into main Jan 6, 2024
14 checks passed
@KillariDev KillariDev deleted the tokens-pages branch January 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants