Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change some branding and remove misc stuff #46

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

KillariDev
Copy link

No description provided.

@KillariDev KillariDev marked this pull request as ready for review January 8, 2024 14:16
CONTRIBUTING.md Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we should keep this one, or perhaps move instructions elsewhere? We could perhaps remove some of the content, or move some to the README, but there should be instructions for how to build/install somewhere.

Comment on lines 11 to 13
- [V1](https://hackmd.io/C-DvwDSfSxuh-Gd4WKE_ig)
- [V2](https://uniswap.org/whitepaper.pdf)
- [V3](https://uniswap.org/whitepaper-v3.pdf)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we inline these into this repository and remove the external links? Or perhaps pin them on IPFS?

Comment on lines -23 to -27
## Accessing the Uniswap Interface

To access the Uniswap Interface, use an IPFS gateway link from the
[latest release](https://github.com/Uniswap/uniswap-interface/releases/latest),
or visit [app.uniswap.org](https://app.uniswap.org).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels useful, but in need of being rewritten with IPFS/ENS instructions.

public/manifest.json Outdated Show resolved Hide resolved
Base automatically changed from treat-british-people-like-other-people to main January 9, 2024 07:44
Co-authored-by: Micah Zoltu <micah@zoltu.net>
@KillariDev KillariDev merged commit 19caddc into main Jan 9, 2024
14 checks passed
@KillariDev KillariDev deleted the remove-branding-remove-misc-stuff branch January 9, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants