Added support for hosting from a subfolder #248
Conversation
✅ Deploy Preview for kaleidoscopic-pudding-244d33 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jubalm
force-pushed
the
feature/ipfs-subpath-support
branch
from
b0bc6a9
to
fee1fb3
Compare
app/index.html
Outdated
| <!-- support hosting from a subpath such as ipfs --> | ||
| <script> | ||
| const baseElement = document.createElement('base') | ||
| baseElement.setAttribute('href', window.location.href.replace(/\/+$/, '') + '/') | ||
| document.head.appendChild(baseElement) | ||
| </script> |
There was a problem hiding this comment.
Why is this necessary? Why not just include a <base href='.'> element in <head>? Does this not work and you have to include an explicit base path? That feels wrong to me. 🤔
If the document has no elements, then baseURI defaults to location.href
There was a problem hiding this comment.
Replaced location.href strategy of parsing subpath by using location.pathname
window.location.pathname.substring(0, window.location.pathname.lastIndexOf('/'))This commit enable support for hosting as /subpath/, /subpath/, /subpath/index.html and appropriately injects only when needed.
app/index.html
Outdated
|
|
||
| <!-- support hosting from a subpath such as ipfs --> | ||
| <script> | ||
| const subPath = window.location.pathname.substring(0, window.location.pathname.lastIndexOf('/')) |
There was a problem hiding this comment.
'/subfolder'.lastIndexOf('/') === 0I don't think this will do what you want as it will strip the subfolder, but we want to keep it.
There was a problem hiding this comment.
| const subPath = window.location.pathname.substring(0, window.location.pathname.lastIndexOf('/')) | |
| const subPath = window.location.pathname.endsWith('index.html') | |
| ? window.location.pathname.substring(0, window.location.pathname.length - 'index.html'.length) | |
| : window.location.pathname |
I think something like this may work? Double check that a base href of '/subfolder' and '/subfolder/' work the same though, as this will not add a trailing slash if it is missing.
There was a problem hiding this comment.
I just made it so that it will always remove index.html if it's in the path and just take the subpath from out of it by removing the trailing slash. will re-add it later as needed by the base element.
const subPath = window.location.pathname.replace('index.html', '').replace(/\/$/, '')
/paths to relative path./Resolves #246
There may still be errors in the page before the base href was set but most modern browsers will find the files after the switch; at least on Chrome and Firefox was tested ok