Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cflags system and make objects be specified per-version #118

Merged
merged 10 commits into from
Feb 20, 2024

Conversation

TheNathannator
Copy link
Contributor

  • The cflag system now allows inheriting from another set of cflags. Inheritance is evaluated bottom-up, starting with includes first.
  • I reorganized cflags to more easily allow lib-specific optimization flags as needed, and added in a bunch of flag sets for libraries in the project.
  • Objects are now specified per-version, since not all objects are compiled the same way on all versions.
  • Both the flag and object versioning files now have schemas, for documentation and editor validation support.
  • I disabled the Missing configuration for <...> logging since all it does for us now is just spam the console when reconfiguring.
  • I added another VS Code task for ninja diff, and made the ninja task the default build task, since that makes more sense than just building the current file.

@TheNathannator
Copy link
Contributor Author

Before I forget:

One caveat of the new cflags/object system is that Ninja will not auto-config on changes anymore, a manual re-config is needed. I'm not sure how to get Ninja to check flags.json/objects.json for changes and reconfigure accordingly.

@TheNathannator TheNathannator marked this pull request as draft February 20, 2024 09:31
@TheNathannator TheNathannator marked this pull request as ready for review February 20, 2024 10:22
@TheNathannator
Copy link
Contributor Author

Got that figured out and fixed, it now once again auto-configures on modification.

@DarkRTA DarkRTA merged commit 821fb03 into DarkRTA:master Feb 20, 2024
1 check passed
@TheNathannator TheNathannator deleted the versioned-objects branch February 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants