refactor: Rewrite BehaviorMessage classes to use member initialization, preferred member naming conventions, and const-ref getters #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadebenn
commented
Feb 11, 2024
There was a problem hiding this comment.
This leaves out the use of unique pointers, use of string_views, and reduction of raw pointers featured in #1452 in order to minimize the (unfortunately still large) amount of code touched. I will probably split each of those aforementioned points into individual PRs as well after this one is or isn't approved.
jadebenn
changed the title
|
Whoops, sorry about the inadvertent assignment there. Wrong button. |
aronwk-aaron
previously approved these changes
Feb 11, 2024
jadebenn
commented
Feb 11, 2024
dGame/dPropertyBehaviors/ControlBehaviorMessages/AddStripMessage.cpp
Outdated
Show resolved
Hide resolved
aronwk-aaron
approved these changes
Feb 12, 2024
|
I understand if there's reluctance to go through this because of its size, but this was about the most focused I could make these changes. It's just three things (member naming, ordering, and functions) altered over that amount of files. |
EmosewaMC
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes split out from #1452 for more focused PR.