-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mercenary Tokens #641
Mercenary Tokens #641
Conversation
okay, conflicts resolved |
Unfortunately cannot Testmerge as it conflics with #628 , due to both modifying Will be on the backburner of TM once nets can be fine-tuned with player input. |
Now that nets are fullmerged, we can give this one a try, as promised. |
Welp, fml, Dromkii's copper PR made conflicts with this one again... please fix the icon issues so I can testmerge it back...I'm really sorry about this happening twice already. |
Can't use the token as a Boltslinger; it just gives the 'I do not belong to the Guild' !merc and !merchant message. It may not have been signed, though. |
weird, i'll test it |
thank you for pointing this out <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks in order, mail fix worked by all accounts.
About The Pull Request
Adds a new "Luxury" item for Merchants and gives them one in their loadout. Mercenary Tokens are paper-like items that can be signed ONLY by the Merchant, then sent by any Mercenary through a mailbox for a one-time reward of three triumphs and a background-specific vanity item.
Why It's Good For The Game
Gives mercenaries a more or less end-game objective to work towards via an item that they cannot acquire by themselves. Merchants now play a more direct role as their handlers, and can choose to sell pre-signed tokens for nobles to do their own recruiting, or send mercenaries on jobs and reward them only when those jobs are completed.
Gives another non-antag way to earn triumphs - an equivalent of half a round's worth that does not require you to survive its entirety.
Tokens can only be signed by the Merchant to prevent Lords rushing their shop and then buying their own mercs out.
The price is a little on the cheaper end - but the intention is for Merchants to jack it up depending on customer or mercenary.
Pre-Merge Checklist