Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio AdaptationSet preference based on AudioChannelConfiguration #3032

Closed
japettyjohn opened this issue Jul 17, 2019 · 3 comments
Closed

Audio AdaptationSet preference based on AudioChannelConfiguration #3032

japettyjohn opened this issue Jul 17, 2019 · 3 comments
Labels
stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed

Comments

@japettyjohn
Copy link

When playing file with multiple audio AdaptatioSets with different AudioChannelConfiguration to support stereo and surround dashjs appears to choose surround on computers with two speakers as long as the surround codec is support. As it's AAC stereo and E-AC-3 surround this only happens on browsers that support E-AC-3 (e.g. Safari). I'm using dash.js 3.0 using videojs 7.5.5.

This is similar to what I brought up in #3022 but in the case of audio it needs to take into account both supported codec (which is does correctly) and the AudioChannelConfiguration.

Here's the audios from my file:

    <AdaptationSet id="0" contentType="audio" lang="en" subsegmentAlignment="true">
      <Representation id="0" bandwidth="164894" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="48000">
        <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/>
        <BaseURL>stereo.mp4</BaseURL>
        <SegmentBase indexRange="825-6748" timescale="48000">
          <Initialization range="0-824"/>
        </SegmentBase>
      </Representation>
    </AdaptationSet>
    <AdaptationSet id="1" contentType="audio" lang="en" subsegmentAlignment="true">
      <Representation id="1" bandwidth="195858" codecs="ec-3" mimeType="audio/mp4" audioSamplingRate="48000">
        <AudioChannelConfiguration schemeIdUri="tag:dolby.com,2014:dash:audio_channel_configuration:2011" value="F801"/>
        <BaseURL>surround.mp4</BaseURL>
        <SegmentBase indexRange="771-6694" timescale="48000">
          <Initialization range="0-770"/>
        </SegmentBase>
      </Representation>
    </AdaptationSet>
@japettyjohn
Copy link
Author

I made a sample which shows this happening using a short clip from Tears of Steel.

@stale
Copy link

stale bot commented Feb 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Feb 26, 2021
@stale
Copy link

stale bot commented Mar 5, 2021

This issue has been automatically closed because no further activity occurred. If you think this issue is still relevant please reopen it. Thank you for your contributions.

@stale stale bot closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed
Projects
None yet
Development

No branches or pull requests

1 participant