Model variant grc reunion #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement grc variant implement internal fluxes
Add grc model structure scheme to the documentation
pag13
requested changes
Sep 7, 2024
There was a problem hiding this comment.
Ok to include this more parameterized structure this way from previous version.
Not the right style of diagram upgrade accordingly please (cf. pptx file provided in the git)
| :math:`c_l` the maximum capacity of the slow-transfer reservoir, | ||
| :math:`k_{exc}` the exchange coefficient, :math:`a_{exc}` the exchange threshold, :math:`h_i` the state of the interception reservoir, | ||
| :math:`h_p` the state of the production reservoir and :math:`h_t` the state of the transfer reservoir, | ||
| :math:`h_l` the state of the slow transfer reservoir. |
There was a problem hiding this comment.
h_t and h_l not in agreement with notation on diagram (update diagram since this is h_t l in code below)
|
Closed and replaced by #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voici une nouvelle variante de modélisation spéciale Réunion : Grc
-> rebaser sur main le 04/09/2024 (le merge devrait être facile)
-> j'ai ajouté la doc + un schéma
-> un nouveau paramètre en plus pour le second réservoir de transfert: cl
-> make tap
Pb rencontrés:
-> la doc de compile pas à cause du pb suivant qui m'échappe (j'ai pas touché à ces fichiers)
/smash/doc/source/api_reference/sub-packages/factory.rst:32:la table des matières contient des références à des documents inexistants 'api_reference/sub-packages/smash/smash.factory.Net.add_dense' [toc.not_readable]
An error occurred while generating the documentation. Returning to previous version.
Merci :)