Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code smell in arLink #139

Open
JoepVanlier opened this issue Jan 30, 2019 · 0 comments
Open

Code smell in arLink #139

JoepVanlier opened this issue Jan 30, 2019 · 0 comments
Labels
task

Comments

@JoepVanlier
Copy link
Member

There is some code smell in arLink.

There are several arguments for adding temporary data points here specifically for arPPL. The datapoints added here are hardcoded to go into the ppl substruct.

This should really be refactored to use arAddData instead.

Tasks:

  1. Develop test for arPPL.
  2. Refactor arLink and arPPL to separate concerns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoepVanlier