Move manifest object key from service to generator (#2778)

[hannes-ucsc]

Author

• PR title references issue
• Title of main commit references issue
• PR is linked to Zenhub issue

Author (reindex)

• Added r tag to commit title _{or this PR does not require reindexing}
• Added reindex label to PR _{or this PR does not require reindexing}

Author (freebies & chains)

• Freebies are blocked on this PR _{or there are no freebies in this PR}
• Freebies are referenced in commit titles _{or there are no freebies in this PR}
• This PR is blocked by previous PR in the chain _{or this PR is not chained to another PR}
• Added chain label to the blocking PR _{or this PR is not chained to another PR}

Author (upgrading)

• Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading}
• Added u tag to commit title _{or this PR does not require upgrading}
• Added upgrade label to PR _{or this PR does not require upgrading}

Author (requirements, before every review)

• Ran make requirements_update _{or this PR leaves requirements*.txt, common.mk and Makefile untouched}
• Added R tag to commit title _{or this PR leaves requirements*.txt untouched}
• Added reqs label to PR _{or this PR leaves requirements*.txt untouched}

Author (before every review)

• make integration_test passes in personal deployment _{or this PR does not touch functionality that could break the IT}
• Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

• Commented in issue about demo expectations _{or labelled issue as no demo}
• Decided if PR can be labeled no sandbox
• PR title is appropriate as title of merge commit
• Moved ticket to Approved column
• Assigned PR to an operator

Operator (before pushing merge the commit)

• Checked reindex label and r commit title tag
• Checked that demo expectations are clear _{or issue is labeled as no demo}
• Rebased and squashed branch
• Sanity-checked history
• Pushed PR branch to Github
• Branch pushed to Gitlab _{or PR is labeled no sandbox}
• Build passes in sandbox and added sandbox label _{or PR is labeled no sandbox}
• Started reindex in sandbox _{or this PR does not require reindexing sandbox}
• Checked for failures in sandbox _{or this PR does not require reindexing sandbox}
• Added PR reference to merge commit title
• Collected commit title tags in merge commit title
• Moved linked issue to Merged column
• Pushed merge commit to Github

Operator (after pushing the merge commit)

• Moved freebies to Merged column _{or there are no freebies in this PR}
• Shortened the PR chain _{or this PR is not the base of another PR}
• Verified that N reviews labelling is accurate Not applicable
• Pushed merge commit to Gitlab _{or this changes can be pushed later, together with another PR}
• Deleted PR branch from Github and Gitlab

Operator (reindex)

• Started reindex in dev _{or this PR does not require reindexing or does not target dev}
• Checked for failures in dev _{or this PR does not require reindexing or does not target dev}
• Started reindex in prod _{or this PR does not require reindexing or does not target prod}
• Checked for failures in prod _{or this PR does not require reindexing or does not target prod}

Operator

• Unassigned PR

[codecov]

Codecov Report

Merging #3104 (072ea68) into develop (166bba0) will increase coverage by 0.02%.
The diff coverage is 97.72%.

@@             Coverage Diff             @@
##           develop    #3104      +/-   ##
===========================================
+ Coverage    82.48%   82.50%   +0.02%     
===========================================
  Files          115      115              
  Lines        12270    12279       +9     
===========================================
+ Hits         10121    10131      +10     
+ Misses        2149     2148       -1     

Impacted Files	Coverage Δ
src/azul/service/manifest_service.py	97.20% <97.29%> (+0.22%)	⬆️
test/service/test_manifest.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166bba0...072ea68. Read the comment docs.

[coveralls]

Coverage increased (+0.02%) to 83.078% when pulling 072ea68 on issues/hannes/2778-partitioned-manifests-3 into 166bba0 on develop.

[nadove-ucsc]

Pro-forma approval to facilitate merge into develop.

[amarjandu]

pro-forma approval in order to merge into develop