Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitLab to 16.3.2 and ClamAV to 1.2.0-1 (#4014) #5523

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

achave11-ucsc
Copy link
Member

@achave11-ucsc achave11-ucsc commented Sep 12, 2023

Connected issue: #4014

Checklist

Author

Author (deploy)

  • Deployed changes to dev.gitlab
  • Deployed changes to anvildev.gitlab
  • Deployed changes to anvilprod.gitlab
  • Deployed changes to prod.gitlab

Primary reviewer (after approval)

  • Verified background migrations for dev.gitlab are complete
  • Verified background migrations for anvildev.gitlab are complete
  • Verified background migrations for anvilprod.gitlab are complete
  • Verified background migrations for prod.gitlab are complete
  • Actually approved the PR
  • Labeled connected issue as no demo
  • Labeled PR as no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to current operator

Operator (before pushing merge the commit)

  • Squashed PR branch and rebased onto develop
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Title of merge commit starts with title from this PR
  • Added PR reference to merge commit title
  • Added commit title tags to merge commit title
  • Moved connected issue to Merged column in ZenHub
  • Pushed merge commit to GitHub

Operator (chain shortening)

  • Changed the target branch of the blocked PR to develop or this PR is not labeled base
  • Removed the chained label from the blocked PR or this PR is not labeled base
  • Removed the blocking relationship from the blocked PR or this PR is not labeled base
  • Removed the base label from this PR or this PR is not labeled base

Operator (after pushing the merge commit)

  • Deleted PR branch from GitHub

Operator

  • Unassigned PR

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 12, 2023
@coveralls
Copy link

coveralls commented Sep 12, 2023

Coverage Status

coverage: 83.726%. remained the same when pulling 0cefe76 on gitlab/2023-09-12/v16.3.2 into 326def5 on develop.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (326def5) 83.70% compared to head (0cefe76) 83.70%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5523   +/-   ##
========================================
  Coverage    83.70%   83.70%           
========================================
  Files          152      152           
  Lines        18705    18705           
========================================
  Hits         15657    15657           
  Misses        3048     3048           
Files Changed Coverage Δ
src/azul/__init__.py 81.53% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Sep 13, 2023
@achave11-ucsc achave11-ucsc merged commit 9ed3eb3 into develop Sep 13, 2023
9 checks passed
@achave11-ucsc achave11-ucsc deleted the gitlab/2023-09-12/v16.3.2 branch September 13, 2023 18:12
@achave11-ucsc achave11-ucsc removed their assignment Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants