-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining moderate & low security issues [BW-774] #730
Conversation
LGTM for now! Btw it's not necessary to use blessed in all stages of a Dockerfile, we only care about the last stage (which is used at runtime). |
@dinvlad TIL, thanks. It can't hurt though, right? If someone compromises an image used in a non-final stage, that could still contaminate the end product, I would think. |
Yep, good point! Trivy is mostly a runtime requirement on our side, since it reveals vulnerabilities that could potentially be exploited once the service is deployed in prod. It does not scan for "malicious" images afaik (although some have reported it detects things like cryptomining bots). In addition, we're only scanning for OS-level dependencies and omit others (e.g. Python/Java packages etc., for which we use SourceClear instead). So you can treat it as just a "compliance checkmark" :-) |
Makes sense. To be honest, I didn't know that much about how Docker image building worked before this ticket, so I cast a wide net. |
@@ -1,12 +1,11 @@ | |||
# Job Manager | |||
|
|||
[![CircleCI branch](https://img.shields.io/circleci/project/github/DataBiosphere/job-manager/master.svg?label=Tests%20on%20Circle%20CI&style=flat-square)](https://circleci.com/gh/DataBiosphere/job-manager/tree/master) | |||
![Github](https://img.shields.io/badge/Supported%20Backends-cromwell%20%7C%20dsub-blue.svg?&style=flat-square) | |||
![Github](https://img.shields.io/badge/Supported%20Backends-cromwell-blue.svg?&style=flat-square) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that only updates after merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can preview it by checking out the branch and viewing in IntelliJ markdown split view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
The more base images we can convert to blessed ones, the better.