Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining moderate & low security issues [BW-774] #730

Merged
merged 7 commits into from
Aug 3, 2021
Merged

Conversation

aednichols
Copy link
Collaborator

The more base images we can convert to blessed ones, the better.

@aednichols aednichols requested a review from dinvlad July 30, 2021 19:49
@dinvlad
Copy link
Contributor

dinvlad commented Jul 30, 2021

LGTM for now! Btw it's not necessary to use blessed in all stages of a Dockerfile, we only care about the last stage (which is used at runtime).

@aednichols
Copy link
Collaborator Author

it's not necessary to use blessed in all stages of a Dockerfile

@dinvlad TIL, thanks. It can't hurt though, right? If someone compromises an image used in a non-final stage, that could still contaminate the end product, I would think.

@dinvlad
Copy link
Contributor

dinvlad commented Aug 2, 2021

Yep, good point! Trivy is mostly a runtime requirement on our side, since it reveals vulnerabilities that could potentially be exploited once the service is deployed in prod. It does not scan for "malicious" images afaik (although some have reported it detects things like cryptomining bots). In addition, we're only scanning for OS-level dependencies and omit others (e.g. Python/Java packages etc., for which we use SourceClear instead). So you can treat it as just a "compliance checkmark" :-)

@aednichols
Copy link
Collaborator Author

Makes sense. To be honest, I didn't know that much about how Docker image building worked before this ticket, so I cast a wide net.

@@ -1,12 +1,11 @@
# Job Manager

[![CircleCI branch](https://img.shields.io/circleci/project/github/DataBiosphere/job-manager/master.svg?label=Tests%20on%20Circle%20CI&style=flat-square)](https://circleci.com/gh/DataBiosphere/job-manager/tree/master)
![Github](https://img.shields.io/badge/Supported%20Backends-cromwell%20%7C%20dsub-blue.svg?&style=flat-square)
![Github](https://img.shields.io/badge/Supported%20Backends-cromwell-blue.svg?&style=flat-square)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that cromwell-sub is still showing.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that only updates after merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can preview it by checking out the branch and viewing in IntelliJ markdown split view

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@aednichols aednichols merged commit 6656751 into master Aug 3, 2021
@aednichols aednichols deleted the aen_bw_774 branch August 3, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants