Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security updates [BT-606] #744

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Security updates [BT-606] #744

merged 1 commit into from
Apr 7, 2022

Conversation

jgainerdewar
Copy link
Collaborator

@jgainerdewar jgainerdewar commented Apr 6, 2022 •
edited
Loading

Resolves security issues in non-dev dependencies. After applying these updates I brought up the app locally and clicked around through everything I could see, seems to work normally.

mspector
mspector approved these changes Apr 7, 2022
View reviewed changes
Copy link

@mspector mspector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

breilly2
breilly2 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@breilly2 breilly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I didn't test, but looks good to me. The biggest risk is the significant major version bump to node-sass, but most of the breaking changes are just removing support for older versions of node. As long as we're on 12+, we should be fine.

@jgainerdewar jgainerdewar merged commit 99c648d into master Apr 7, 2022
@jgainerdewar jgainerdewar deleted the jgd_bt_606_upgrade branch April 7, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breilly2 breilly2 breilly2 approved these changes

@mspector mspector mspector approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgainerdewar @mspector @breilly2