Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jupyter UI #225

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Update Jupyter UI #225

merged 6 commits into from
Jul 18, 2024

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Jul 17, 2024

Upgrade:

  • enable auto config of the kubegraph endpoint (avoiding first cell to be ran)
  • enabling auto-run of the visualisation setup
  • updating jupyter to new version
  • add support for lab version of jupyter (http://127.0.0.1:8889/lab)

Fix:

  • Fix issue with cookie on login with jupyter

Minosity-VR
Minosity-VR reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Minosity-VR Minosity-VR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM little nits but overall great!
Testing locally before approving

deployments/kubehound/notebook/Dockerfile Show resolved Hide resolved
deployments/kubehound/notebook/KubehoundDSL_101.ipynb Show resolved Hide resolved
deployments/kubehound/notebook/notebook.json Outdated Show resolved Hide resolved
@jt-dd jt-dd marked this pull request as ready for review July 18, 2024 09:04
@jt-dd jt-dd requested a review from a team as a code owner July 18, 2024 09:04
@jt-dd jt-dd merged commit 265f490 into main Jul 18, 2024
7 checks passed
@jt-dd jt-dd deleted the jt-dd/updating-ui-jupyter branch July 18, 2024 09:06
Minosity-VR
Minosity-VR reviewed Jul 18, 2024
View reviewed changes
deployments/kubehound/docker-compose.yaml
@@ -45,6 +46,7 @@ services:
- kubeui_data:/root/notebooks/shared
environment:
- NOTEBOOK_PASSWORD=admin
- GRAPH_NOTEBOOK_SSL=False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From talking with Julien - needed because kubegraph doesn't expose a https endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minosity-VR Minosity-VR Minosity-VR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jt-dd @Minosity-VR