Add event hooks to client #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmuldavin
force-pushed
the
noah.muldavin/verify-required-capability-installation
branch
2 times, most recently
from
7d58127
to
1036a7f
Compare
* Add init hook, exposed through postmate model. Must be called by parent after handshake with app context data before all other operations may proceed.
* Add exec hook, exposed through postmate model, for the parent to send events to the child.
* Add `on` event handler subscription method, with subscribe and unsubscribe logic
* Add checks in `exec` handler verifying that the user installation includes the capabilities necessary to recieve an event of the given type. If not, a debug error is logged and the subscribed handler is not executed.
nmuldavin
force-pushed
the
noah.muldavin/verify-required-capability-installation
branch
from
1036a7f
to
6f09aaa
Compare
enbashi
approved these changes
Oct 8, 2020
nmuldavin
force-pushed
the
noah.muldavin/verify-required-capability-installation
branch
from
6351efd
to
6640de3
Compare
nmuldavin
deleted the
noah.muldavin/verify-required-capability-installation
branch
Ignore thisThere was an issue when setting up 🚀 PR was released in |
Ignore thisThere was an issue when setting up 🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onevent handler subscription method, with subscribe and unsubscribe logicexechandler verifying that the user installation includes the capabilities necessary to recieve an event of the given type. If not, a debug error is logged and the subscribed handler is not executed.