Remove some anys from custom widgets
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to remove the `any` and be a bit more precise. We split things into a base, boolean, and string interfaces. This allows us to replace the `any` with the appropriate type for each `type`. This also means that we can remove the `enum` entirely from `WidgetOptionItemBoolean` (since there's no valid enumeration that isn't `false`/`true`).
We want to remove the `any`. Since we currently only allow string and boolean options, we can give the type of `options` a more accurate type than `any`.
enbashi
approved these changes
Sep 9, 2021
|
Thanks for the review! |
Ignore thisThere was an issue when setting up 🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change how we define custom widget options so they can be typed a bit stricter and remove some
anys in the process.Docs PR: #16