✨[RUMF-315] collect initial document timing #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/timing
branch
from
8927faf
to
5709c58
Compare
bcaudan
commented
Feb 19, 2020
| @@ -17,7 +18,7 @@ import { | |||
|
|
|||
| beforeEach(async () => { | |||
| // tslint:disable-next-line: no-unsafe-any | |||
| await browser.url(`/${(browser as any).config.e2eMode}-e2e-page.html`) | |||
| await browser.url(`/${(browser as any).config.e2eMode}-e2e-page.html?cb=${Date.now()}`) | |||
There was a problem hiding this comment.
add cache busting to avoid funny timings on safari due to document caching
convert performance.timing avialable timestamps to relative times
set fake initiator type to identify `document` kind
bcaudan
force-pushed
the
bcaudan/timing
branch
from
5709c58
to
adf3131
Compare
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 86.06% 85.98% -0.09%
==========================================
Files 24 24
Lines 1313 1334 +21
Branches 280 283 +3
==========================================
+ Hits 1130 1147 +17
- Misses 183 187 +4
Continue to review full report at Codecov.
|
BenoitZugmeyer
requested changes
Feb 19, 2020
BenoitZugmeyer
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send an event resource for the initial document