👷 Skip Safari and IE for extension Browserstack unit tests #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
nulrich
reviewed
Jun 18, 2024
cy-moi
commented
Jun 19, 2024
package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "test": "yarn test:unit:watch", | |||
| "test:unit": "karma start ./test/unit/karma.local.conf.js", | |||
| "test:unit:watch": "yarn test:unit --no-single-run", | |||
| "test:unit:bs": "node ./scripts/test/bs-wrapper.js karma start test/unit/karma.bs.conf.js", | |||
| "test:unit:bs": "node ./scripts/test/bs-wrapper.js karma start test/unit/karma.bs.conf.js && node ./scripts/test/bs-wrapper.js karma start test/unit/karma.bs.conf.js --ext", | |||
There was a problem hiding this comment.
Question❓: shall we proceed with skipping the Browserstack tests for the extension completely as we were already running it on headless chrome?
There was a problem hiding this comment.
I think this would be simpler, yes!
test/unit/karma.bs.conf.js
Outdated
Comment on lines
2
to
21
| let { browserConfigurations } = require('../browsers.conf') | ||
|
|
||
| const karmaBaseConf = require('./karma.base.conf') | ||
|
|
||
| const isExtension = process.argv.includes('--ext') | ||
| browserConfigurations = isExtension | ||
| ? browserConfigurations.filter((configuration) => !['ie', 'safari'].includes(configuration.name.toLowerCase())) | ||
| : browserConfigurations | ||
|
|
||
| module.exports = function (config) { | ||
| config.set({ | ||
| ...karmaBaseConf, | ||
| files: isExtension ? [...karmaBaseConf.files, 'developer-extension/src/**/*.spec.ts'] : karmaBaseConf.files, | ||
| plugins: [...karmaBaseConf.plugins, 'karma-browserstack-launcher'], | ||
| preprocessors: isExtension | ||
| ? { | ||
| ...karmaBaseConf.preprocessors, | ||
| 'developer-extension/src/**/*.ts': ['webpack', 'sourcemap'], | ||
| } | ||
| : karmaBaseConf.preprocessors, |
There was a problem hiding this comment.
💬 suggestion: this is not needed anymore, maybe remove it?
rum-events-format
Outdated
There was a problem hiding this comment.
Changes to the rum-events-format and telemetry event types are unrelated, could you revert them?
amortemousque
approved these changes
Jun 21, 2024
nulrich
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We do not need to run extension tests on Safari or IE
Changes
Add a browser configuration for extension only karma test.
Testing
I have gone over the contributing documentation.