🧪 Ensure skipped test do not fail

[nulrich]

Motivation

Some of our tests are skipped but have runtime issues. Jasmine considers them as skipped but DD Test Visibility as failed.

Changes

Ensuring that we do not execute the body of afterEach if we skipped the test in beforeEach.

Adding a Karma reporter to warn when we have failed skipped tests.

Testing

Test Visibility

---

I have gone over the contributing documentation.

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	160.25 KiB	160.25 KiB	0 B	0.00%	✅
Logs	57.91 KiB	57.91 KiB	0 B	0.00%	✅
Rum Slim	108.77 KiB	108.77 KiB	0 B	0.00%	✅
Worker	25.21 KiB	25.21 KiB	0 B	0.00%	✅

🚀 CPU Performance

Action Name	Base Average Cpu Time (ms)	Local Average Cpu Time (ms)	𝚫
addglobalcontext	0.002	0.001	-0.000
addaction	0.031	0.032	0.001
adderror	0.032	0.032	0.000
addtiming	0.001	0.001	0.000
startview	0.877	0.885	0.008
startstopsessionreplayrecording	0.844	0.827	-0.017
logmessage	0.020	0.019	-0.001

🧠 Memory Performance

Action Name	Base Consumption Memory (bytes)	Local Consumption Memory (bytes)	𝚫 (bytes)
addglobalcontext	21.57 KiB	19.68 KiB	-1937 B
addaction	72.37 KiB	72.49 KiB	122 B
adderror	87.43 KiB	85.78 KiB	-1694 B
addtiming	19.62 KiB	17.71 KiB	-1953 B
startview	314.20 KiB	319.27 KiB	5.06 KiB
startstopsessionreplayrecording	16.82 KiB	15.54 KiB	-1315 B
logmessage	67.43 KiB	70.33 KiB	2.90 KiB

🔗 RealWorld

[BenoitZugmeyer]

👏 praise: ‏Great!

[BenoitZugmeyer]

💬 suggestion: ‏Instead of duplicating the condition in afterEach (which is error-prone, as it can be forgotten), you could leverage registerCleanupTask in beforeEach and remove the afterEach usage. For example, in this test, we could write:

 beforeEach(() => {
    if (isIE()) {
      pending('no fetch support')
    }
    fetchStubManager = stubFetch()
    originalFetchStub = window.fetch
    requests = []
    requestsTrackingSubscription = initFetchObservable().subscribe((context) => {
      if (context.state === 'resolve') {
        requests.push(context)
      }
    })
    fetchStub = window.fetch as FetchStub
    registerCleanupTask(() => {
      requestsTrackingSubscription.unsubscribe()
      fetchStubManager.reset()
    })
  })

This could be a step toward https://datadoghq.atlassian.net/browse/RUM-5101