[test] Fix open handles in unit tests #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
commented
Nov 14, 2023
| @@ -1,6 +1,6 @@ | |||
| module.exports = { | |||
| clearMocks: true, | |||
| moduleFileExtensions: ['js', 'ts'], | |||
| moduleFileExtensions: ['js', 'ts', 'node'], | |||
There was a problem hiding this comment.
This addition solves this issue. Found the solution here: jestjs/jest#1694 (comment)
Drarig29
commented
Nov 14, 2023
Comment on lines
+40
to
+41
| const task = await new MockTestRunner().LoadAsync(file) | ||
| await task.runAsync(nodeVersion) |
There was a problem hiding this comment.
This now has to be async, otherwise this line will do an infinite loop. See this CI, that I had to cancel.
Drarig29
changed the title
Drarig29
commented
Nov 14, 2023
Comment on lines
-43
to
46
| // Warnings usually come from `mockery`, and can be useful to spot mocking issues. | ||
| // Warnings can be useful to spot mocking issues. | ||
| // For example, "Replacing existing mock for module: azure-pipelines-task-lib/task" means | ||
| // that we tried to mock `azure-pipelines-task-lib/task`, which is already mocked | ||
| // by `azure-pipelines-task-lib/mock-run`. So our mock would be overwritten. |
There was a problem hiding this comment.
They removed mockery (microsoft/azure-pipelines-task-lib#968), and Replacing existing mock for module can still be logged, so I updated the comment.
jakepruitt
approved these changes
Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix this issue:
This is caused by
azure-pipelines-task-lib, which used to usesync-request(a way to synchronously make a request, which they use to download Node.js before running the unit tests).This
sync-requestpackage is known for leaving orphan processes (ForbesLindesay/sync-request#137) at import time and it recently had some vulnerabilities, which led Microsoft to remove this dependency (microsoft/azure-pipelines-task-lib#932), hence the need to bumpazure-pipelines-task-lib: 07464dd