Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-3035] CODEOWNERS support for test visibility #98

Merged
merged 13 commits into from
Jan 9, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jan 5, 2024

What does this PR do?
Adds Codeowners tag support to show owners for each test

image

Motivation
Achieving feature parity with other libraries before GA

How to test the change?
Tested using https://github.com/anmarchenko/sidekiq (see screenshot above)

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (867b86e) 99.19% compared to head (8e59911) 99.19%.

Files Patch % Lines
lib/datadog/ci/codeowners/matcher.rb 96.07% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main      #98    +/-   ##
========================================
  Coverage   99.19%   99.19%            
========================================
  Files         142      147     +5     
  Lines        5988     6242   +254     
  Branches      235      256    +21     
========================================
+ Hits         5940     6192   +252     
- Misses         48       50     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review January 8, 2024 12:21
@anmarchenko anmarchenko requested review from a team and tonyredondo January 8, 2024 12:21
@anmarchenko anmarchenko changed the title CODEOWNERS support for test visibility [CIVIS-3035] CODEOWNERS support for test visibility Jan 8, 2024
@anmarchenko anmarchenko merged commit dc38a5b into main Jan 9, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/codeowners branch January 9, 2024 13:39
@anmarchenko anmarchenko added this to the 0.7.0 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants