Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD_SERVICE_MAPPING implementation for inferred spans #333

Merged
merged 11 commits into from
Jun 6, 2023
Merged

DD_SERVICE_MAPPING implementation for inferred spans #333

merged 11 commits into from
Jun 6, 2023

Conversation

zARODz11z
Copy link
Contributor

@zARODz11z zARODz11z commented May 16, 2023 •
edited
Loading

What does this PR do?

allows users to remap the service name on inferred spans created in dd lambda js. Pairs with DataDog/documentation#18144

Motivation

SLS-3501

Testing Guidelines

unit

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@zARODz11z zARODz11z requested a review from a team as a code owner May 16, 2023 17:31
zARODz11z
zARODz11z commented May 18, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
astuyve
astuyve reviewed May 18, 2023
View reviewed changes
datadog_lambda/tracing.py Outdated Show resolved Hide resolved
astuyve
astuyve requested changes May 18, 2023
View reviewed changes
datadog_lambda/tracing.py Outdated Show resolved Hide resolved
datadog_lambda/tracing.py Outdated Show resolved Hide resolved
zARODz11z
zARODz11z commented May 19, 2023
View reviewed changes
tests/test_tracing.py Outdated Show resolved Hide resolved
@zARODz11z zARODz11z requested a review from astuyve May 19, 2023 16:08
joeyzhao2018
joeyzhao2018 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nitpicks

duncanista
duncanista requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just resolve comments!

@zARODz11z zARODz11z merged commit 16f5e4c into main Jun 6, 2023
@zARODz11z zARODz11z deleted the ar/DD_SERVICE_MAPPING branch June 6, 2023 20:40
@zARODz11z zARODz11z changed the title DD_SERVICE_MAPPING implementation with tests DD_SERVICE_MAPPING implementation for inferred spans Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

@astuyve astuyve astuyve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zARODz11z @astuyve @joeyzhao2018 @duncanista