Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links for DDA v2alpha1 examples #1199

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented May 24, 2024

What does this PR do?

Fix dead links for example DDAs on https://github.com/DataDog/datadog-operator/blob/main/docs/configuration.v2alpha1.md. The Manifest with Logs and metrics collection enabled example file was removed entirely so I removed that link.

Motivation

#1176

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added documentation Improvements or additions to documentation qa/skip-qa labels May 24, 2024
@khewonc khewonc requested review from a team as code owners May 24, 2024 20:41
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (8981855) to head (d5327b4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1199   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         175      175           
  Lines       21944    21944           
=======================================
  Hits        12984    12984           
  Misses       8164     8164           
  Partials      796      796           
Flag Coverage Δ
unittests 59.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8981855...d5327b4. Read the comment docs.

Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for docs!

@datadog-datadog-prod-us1
Copy link

Software Composition Analysis

We found vulnerabilities in the following libraries (compared 7f4a27e against a900de1):

@khewonc khewonc merged commit 1e0ca4a into main May 29, 2024
19 checks passed
@khewonc khewonc deleted the khewonc/dda-example-404 branch May 29, 2024 19:07
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* Fix dead links

* Modify markdown files

* Fix v1alpha1 example link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants