Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LeaderElectionResourceLock to leases and remove leader-election-resource parameter #1237

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Jun 14, 2024

What does this PR do?

In Operator v1.8 we will upgrade controller-runtime and Kubernetes API dependencies which only supports leases as leader election resource lock.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m added enhancement New feature or request tooling qa/skip-qa labels Jun 14, 2024
@levan-m levan-m added this to the v1.8.0 milestone Jun 14, 2024
@levan-m levan-m requested review from a team as code owners June 14, 2024 20:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (288d981) to head (f2893b2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         177      177           
  Lines       22371    22371           
=======================================
  Hits        13273    13273           
  Misses       8286     8286           
  Partials      812      812           
Flag Coverage Δ
unittests 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288d981...f2893b2. Read the comment docs.

@levan-m levan-m merged commit 40b0c4b into main Jun 17, 2024
25 checks passed
@levan-m levan-m deleted the levan-m/leader-resource-lock branch June 17, 2024 17:27
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants