Add global environment variable config #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
+ Coverage 47.40% 47.63% +0.22%
==========================================
Files 223 224 +1
Lines 19244 19522 +278
==========================================
+ Hits 9123 9299 +176
- Misses 9635 9723 +88
- Partials 486 500 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
buraizu
approved these changes
Sep 11, 2024
tbavelier
reviewed
Sep 12, 2024
tbavelier
reviewed
Sep 12, 2024
tbavelier
reviewed
Sep 12, 2024
tbavelier
reviewed
Sep 12, 2024
tbavelier
requested changes
Sep 12, 2024
tbavelier
reviewed
Sep 13, 2024
| @@ -137,6 +137,14 @@ func applyGlobalSettings(logger logr.Logger, manager feature.PodTemplateManagers | |||
| } | |||
| } | |||
|
|
|||
| // Env is a list of custom global variables that are set across all agents. | |||
| if config.Env != nil { | |||
| logger.V(1).Info(fmt.Sprintf("Adding custom environment variable %s", config.Env)) | |||
There was a problem hiding this comment.
Let's discuss with the team offline if we add this log in the end or not
tbavelier
approved these changes
Sep 13, 2024
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* add global environment variable * add tests for global env * update comments * update formatting, logging, config docs * update CRD * remove global env log statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added configuration for global environment variables; environment variables defined in global.env of the Datadog Agent CRD will be set across all agents in Operator.
Motivation
issue 961
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel