-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServiceAccountAnnotations override #1425
Add ServiceAccountAnnotations override #1425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies
9fe8bce
to
821267c
Compare
821267c
to
c482871
Compare
Thanks for opening this PR, @bt-macole ! |
Please let me know what else I can do to help get this feature added. It has been a bit of a pain point for my team and based on #600, for others as well. Would greatly appreciate any help to keep it moving forward. |
c482871
to
2b28595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I had just 1 small comment to update the config name to use lowercase camelcase.
What does this PR do?
This PR introduces
[key].ServiceAccountAnnotations
to the overrides fornodeAgent
,clusterAgent
, andclusterChecksRunner
Resolves #600
Motivation
As noted in #600, using the DD operator has some limitations with respect to easily attaching irsa role annotations to the SA.
Describe your test plan
internal/controller/datadogagent/merger/rbac
andapi/datadoghq/v2alpha1/
tests were updated to validate the spec update can be read and updated following the existing conventions in the dd-operator.Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label