Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceAccountAnnotations override #1425

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

bt-macole
Copy link
Contributor

@bt-macole bt-macole commented Sep 21, 2024

What does this PR do?

This PR introduces [key].ServiceAccountAnnotations to the overrides for nodeAgent, clusterAgent, and clusterChecksRunner

Resolves #600

Motivation

As noted in #600, using the DD operator has some limitations with respect to easily attaching irsa role annotations to the SA.

Describe your test plan

internal/controller/datadogagent/merger/rbac and api/datadoghq/v2alpha1/ tests were updated to validate the spec update can be read and updated following the existing conventions in the dd-operator.

Note: was unable to pul the redhat base image so was unable to build--even before modifying the codebase--so was unable to run the full suite of tests or see final results in kubernetes.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@bt-macole bt-macole requested a review from a team as a code owner September 21, 2024 21:38
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@bt-macole bt-macole force-pushed the cluster-agent-sa-annotations branch 2 times, most recently from 9fe8bce to 821267c Compare September 21, 2024 22:07
@bt-macole bt-macole requested a review from a team as a code owner September 21, 2024 22:07
@bt-macole bt-macole changed the title Cluster agent sa annotations sa annotations override Sep 21, 2024
@bt-macole bt-macole changed the title sa annotations override Add ServiceAccountAnnotations override Sep 22, 2024
@alai97 alai97 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 23, 2024
@alai97
Copy link
Contributor

alai97 commented Sep 23, 2024

Thanks for opening this PR, @bt-macole !

@bt-macole
Copy link
Contributor Author

Thanks for opening this PR, @bt-macole !

Please let me know what else I can do to help get this feature added. It has been a bit of a pain point for my team and based on #600, for others as well. Would greatly appreciate any help to keep it moving forward.

@celenechang celenechang added this to the v1.10.0 milestone Sep 27, 2024
Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I had just 1 small comment to update the config name to use lowercase camelcase.

api/datadoghq/v2alpha1/datadogagent_types.go Outdated Show resolved Hide resolved
@fanny-jiang fanny-jiang merged commit 79d2319 into DataDog:main Oct 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Annotations for serviceAccounts
4 participants