-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric for max goroutines set in the operator #1427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
=======================================
Coverage 48.92% 48.92%
=======================================
Files 222 223 +1
Lines 19432 19438 +6
=======================================
+ Hits 9508 9511 +3
- Misses 9435 9438 +3
Partials 489 489
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
What does this PR do?
Add a metric for max goroutines set in the operator.
Motivation
What inspired you to submit this pull request?
CECO-1181 - sending a metric for max goroutines be helpful as we could graph that in a dashboard so it’s easier to see when goroutines > max goroutines
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
N/A
Describe your test plan
Can adjust the maximumGoroutines configuration by adding
- --maximumGoroutines=<desired max goroutines>
in the args: https://github.com/DataDog/datadog-operator/blob/main/config/manager/manager.yaml#L38Then deploy the DatadogAgent and exec into the agent container and run
curl http://<datadog operator pod IP>:8080/metrics | grep max_goroutines
to see if it reflects the same.Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label