Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric for max goroutines set in the operator #1427

Merged
merged 10 commits into from
Oct 3, 2024

Conversation

mrdoggopat
Copy link
Contributor

What does this PR do?

Add a metric for max goroutines set in the operator.

Motivation

What inspired you to submit this pull request?
CECO-1181 - sending a metric for max goroutines be helpful as we could graph that in a dashboard so it’s easier to see when goroutines > max goroutines

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
N/A

Describe your test plan

Can adjust the maximumGoroutines configuration by adding - --maximumGoroutines=<desired max goroutines> in the args: https://github.com/DataDog/datadog-operator/blob/main/config/manager/manager.yaml#L38

Then deploy the DatadogAgent and exec into the agent container and run curl http://<datadog operator pod IP>:8080/metrics | grep max_goroutines to see if it reflects the same.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@mrdoggopat mrdoggopat added the enhancement New feature or request label Sep 23, 2024
@mrdoggopat mrdoggopat added this to the v1.10.0 milestone Sep 23, 2024
@mrdoggopat mrdoggopat requested review from a team as code owners September 23, 2024 17:55
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.92%. Comparing base (cfaff9d) to head (df678ee).

Files with missing lines Patch % Lines
cmd/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files         222      223    +1     
  Lines       19432    19438    +6     
=======================================
+ Hits         9508     9511    +3     
- Misses       9435     9438    +3     
  Partials      489      489           
Flag Coverage Δ
unittests 48.92% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/metrics/datadogoperator.go 100.00% <100.00%> (ø)
cmd/main.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfaff9d...df678ee. Read the comment docs.

internal/controller/metrics/datadogoperator.go Outdated Show resolved Hide resolved
internal/controller/metrics/datadogoperator.go Outdated Show resolved Hide resolved
@khewonc khewonc merged commit a97d755 into main Oct 3, 2024
19 checks passed
@khewonc khewonc deleted the mrmcpat-maxgoroutine-metric branch October 3, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants