Admission controller: add failure policy, change default apm and dsd socket #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CharlyF
approved these changes
Dec 2, 2022
| apmSocketHostPath = "/var/run/datadog/apm" | ||
| apmSocketPath = "/var/run/datadog/apm/apm.sock" | ||
| apmSocketHostPath = "/var/run/datadog" | ||
| apmSocketPath = "/var/run/datadog/apm.sock" |
There was a problem hiding this comment.
These are not technically necessary - You should rename DogstatsdSocketVolumePath in DogstatsdAPMSocketVolumePath in apis/datadoghq/common/const.go and you have apmSocketPath defined using DogstatsdAPMSocketVolumePath and APMSocketName too.
This is a test file so it's not the most important.
khewonc
added a commit
that referenced
this pull request
Dec 6, 2022
…socket (#643) * Add failure policy, change default apm and dsd socket
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
…socket (#643) * Add failure policy, change default apm and dsd socket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.