Fix to handle partial image overrides input correctly #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 58.55% 58.57% +0.02%
==========================================
Files 144 144
Lines 17345 17355 +10
==========================================
+ Hits 10156 10166 +10
Misses 6581 6581
Partials 608 608
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CharlyF
reviewed
Nov 29, 2022
| @@ -443,3 +514,21 @@ func TestPodTemplateSpec(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func fakePodTemplateManagers(image string, t *testing.T) *fake.PodTemplateManagers { | |||
There was a problem hiding this comment.
maybe you could rename that method to reflect that it's dedicated to give a podTemplateManager with images overidden?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CharlyF
approved these changes
Dec 1, 2022
khewonc
pushed a commit
that referenced
this pull request
Dec 6, 2022
levan-m
added a commit
that referenced
this pull request
Dec 6, 2022
levan-m
added a commit
that referenced
this pull request
Dec 14, 2022
…update documentation (related to #652).
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Proposes a fix for an issue report in this Slack message - summarizing below.
When
override.nodeAgent.imageisn't fully provided the image URI in agent pod/deployment is corrupt.For
Generated image URI is
Same happens with DCA and CCR as well.
Motivation
Fix will allow users to provide only partial overrides and use previuos defaults.
Additional Notes
n/a
Describe your test plan