Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Change default log path on Windows #335

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Conversation

bmermet
Copy link

@bmermet bmermet commented Nov 10, 2017

The previous default log path assumed that the agent was running on a Unix system. This PR fixes that.

@palazzem palazzem added this to the 5.19.1 milestone Nov 10, 2017
@palazzem palazzem added the core label Nov 10, 2017
Copy link

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me, let's wait for Derek review and we're fine.

package config

// DefaultLogFilePath is where the agent will write logs if not overriden in the conf
const DefaultLogFilePath = "c:\\programdata\\datadog\\logs\\trace-agent.log"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwbrown can you confirm?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@palazzem palazzem merged commit f936579 into master Nov 14, 2017
@palazzem palazzem deleted the bmermet/fixwindowslogpath branch November 14, 2017 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants