This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
writer: add transaction stream to trace-writer, dupe of #346 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LotharSee
reviewed
Jan 12, 2018
| if s.engine.Sample(t.Trace, t.Root, t.Env) { | ||
| s.keptTraceCount++ | ||
| s.sampled <- &t.Trace | ||
| } | ||
|
|
||
| // inspect the WeightedTrace so that we can identify top-level spans | ||
| for _, span := range t.WeightedTrace { |
There was a problem hiding this comment.
Neat, it actually plugs easily into the code.
LotharSee
reviewed
Jan 12, 2018
| @@ -118,6 +126,10 @@ func (w *TraceWriter) Run() { | |||
| continue | |||
| } | |||
| w.handleTrace(trace) | |||
| case transaction := <-w.InTransactions: | |||
| // no need for lock for now as flush is sequential | |||
There was a problem hiding this comment.
Outdated comment as #344 got merged?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.