[logging] rename loggers and set handlers to null #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
requested changes
Sep 21, 2016
| @@ -8,7 +8,7 @@ | |||
| from datadog.api.api_client import APIClient | |||
|
|
|||
|
|
|||
| log = logging.getLogger('dd.datadogpy') | |||
| log = logging.getLogger('datadog.api') | |||
| @@ -9,7 +9,7 @@ | |||
| # CONSTANTS | |||
| DATADOG_CONF = "datadog.conf" | |||
|
|
|||
| log = logging.getLogger('dd.datadogpy') | |||
| log = logging.getLogger('datadog.api') | |||
| @@ -22,6 +23,10 @@ | |||
|
|
|||
| __version__ = get_version() | |||
|
|
|||
| # Loggers | |||
| logging.getLogger('datadog.api').addHandler(logging.NullHandler()) | |||
| logging.getLogger('datadog.dogstatsd').addHandler(logging.NullHandler()) | |||
There was a problem hiding this comment.
What about datadog.threadstats ?
Split `dd.datadogpy` logger to one per module, i.e. * `datadog.api` * `datadog.dogstatsd` * `datadog.threadstats` Setup the `NullHandler` handler by default as advised in https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library
yannmh
force-pushed
the
yann/logging-null-handler
branch
from
60f1004
to
8f5f29c
Compare
|
Fix #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
dd.datadogpylogger to one per module, i.e.datadog.apidatadog.dogstatsddatadog.threadstatsSetup the
NullHandlerhandler by default as advised inhttps://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library