Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking connections in dogstatsd #634

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Conversation

therve
Copy link
Contributor

@therve therve commented Feb 23, 2021

This adds back non blocking to UDP and sets non blocking before connect
like it was before.

This adds back non blocking to UDP and sets non blocking before connect
like it was before
@therve therve requested a review from a team as a code owner February 23, 2021 10:07
zippolyte
zippolyte previously approved these changes Feb 23, 2021
@therve
Copy link
Contributor Author

therve commented Feb 24, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@therve therve merged commit 689eb20 into master Feb 25, 2021
@therve therve deleted the therve/fix-non-blocking branch February 25, 2021 08:30
@olivielpeau
Copy link
Member

Thanks for this!

Trying to understand the history of this: it looks like setting non-blocking UDP and setting non blocking before connecting was fixed in #590 (0.39.0) but then mistakenly reverted with #558 (0.40.0).

@therve therve added the changelog/Fixed Fixed features results into a bug fix version bump label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants