[statsd] Improve tag normalization speed #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to exactly see where statsd is spending the majority of its time when processing metrics. The profiling can be activated via `BENCHMARK_PROFILING` variable.
sgnn7
added
changelog/Changed
sgnn7
force-pushed
the
sgnn7/statsd-improve-tag-normalization-speed-main
branch
2 times, most recently
from
ffa4dfc
to
edac974
Compare
Previously, we used a raw string in `re.sub` which is in the hot-path and needed compilation every time so now we use the precompiled version of the regex to do the substitution, yielding a much better performance.
sgnn7
force-pushed
the
sgnn7/statsd-improve-tag-normalization-speed-main
branch
from
edac974
to
68a1ebc
Compare
therve
approved these changes
Jun 30, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zippolyte
added
changelog/Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Speeds up the tag normalization function. By being in the hot path in
statsd, this improves theperformance of
statsdsignificantly (~30% reduction in latency, CPU utilization, and benchmark duration across the board).Since this function is used in the
submit()API too, it may offer significant performance improvement there as well.Description of the Change
normalize_tagsfunctionFixes #671
Alternate Designs
Possible Drawbacks
None
Verification Process
python3 -m unittest -vvv tests.unit.util.test_format.TestNormalizeTagsand/orpython2 -m unittest -vvv tests.unit.util.test_format.TestNormalizeTagsAdditional Notes
Benchmark results vs main branch:
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.