Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statsd] Restore buffering state when exiting context manager #715

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

sgnn7
Copy link
Contributor

@sgnn7 sgnn7 commented Feb 24, 2022

What does this PR do?

When exiting the context or when manual close_buffer is invoked, we
should restore the buffering state that existed before the
context/manual buffer changes were applied.

Fixes: #714

Description of the Change

Buffering state is restored when buffer is manually closed or the managed context is left.

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Unit tests cover the functionality but manual test can be done by following directions in the upstream issue

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

When exiting the context or when manual close_buffer is invoked, we
should restore the buffering state that existed before the
context/manual buffer changes were applied.

Fixes: #714
@sgnn7 sgnn7 added resource/dogstatsd changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/minor Minor severity issue labels Feb 24, 2022
@sgnn7 sgnn7 added this to the 0.44.0 milestone Feb 24, 2022
@sgnn7 sgnn7 requested review from a team as code owners February 24, 2022 21:29
@sgnn7 sgnn7 self-assigned this Feb 24, 2022
@sgnn7
Copy link
Contributor Author

sgnn7 commented Feb 24, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sgnn7 sgnn7 merged commit 8947896 into master Feb 24, 2022
@sgnn7 sgnn7 deleted the sgnn7/restore-buffering-when-using-manual-buffer-ops branch February 24, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue resource/dogstatsd severity/minor Minor severity issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context manager disables buffering on the client
2 participants