Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL check warning #558

Closed
LotharSee opened this issue Jul 1, 2013 · 6 comments
Closed

MySQL check warning #558

LotharSee opened this issue Jul 1, 2013 · 6 comments
Assignees

Comments

@LotharSee
Copy link
Contributor

In the info page:

Warning: Cannot compute mysql version assuming older than 5.0.2: 'MySql' object has no attribute 'db'

Happened on MySQL 5.1.x on Red Hat but also Debian Squeeze.

@ghost ghost assigned LotharSee Jul 1, 2013
@conorbranagan
Copy link
Member

Did this cause any other issues other than just not being able to get the version number? What do we use the version number for?

@LotharSee
Copy link
Contributor Author

As a result, some metrics were wrong.

Some commands changed between <5.0.2 and >5.0.2. We use this version number to know which command to execute.
Exemple: SHOW STATUS LIKE 'Slow_queries' became SHOW GLOBAL STATUS LIKE 'Slow_queries'.

Are concerned:
'mysql.performance.created_tmp_disk_tables', 'mysql.performance.slow_queries', 'mysql.performance.questions', 'mysql.performance.queries'
Without this fix, those 4 metrics are wrong (value 0) on all 5.0.2+ MySQL.

@miketheman
Copy link
Contributor

Can we determine what version this was introduced in, so we can reliably state 'any users with dd-agent version X--Y using MySQL 5.1.x should use version 3.8.1'?

@LotharSee
Copy link
Contributor Author

It is hard to say because I fixed multiple bugs in the same time, and for sure one of them was here since this check was moved to checks.d (Agent 3.6.2). I didn't check if it also concerns the old MySQL check (i.e. before 3.6.2).

Because we probably have other bugs (at least this one: #559), I will probably review the whole check.

@olidb2
Copy link
Member

olidb2 commented Jul 1, 2013

Can we binary-search the versions of the agent by testing them?

On Mon, Jul 1, 2013 at 1:50 PM, Benjamin Fernandes <notifications@github.com

wrote:

It is hard to say because I fixed multiple bugs in the same time, and for
sure one of them was here since this check was moved to checks.d (Agent
3.6.2). I didn't check if it also concerns the old MySQL check.

Because we probably have other bugs (at least this one: #559#559),
I will probably review the whole check.


Reply to this email directly or view it on GitHubhttps://github.com//issues/558#issuecomment-20298316
.

@zorkian
Copy link

zorkian commented Jul 30, 2013

I'm getting this right now. I have 5.5.31-30.3-log from Percona, and a fresh Datadog Agent installed today (just signed up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants