Tracebacks on agent.py info and changed how get_config() receives options and args, fixes #329 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the usages of get_parsed_args() #329
| @@ -73,7 +73,7 @@ def run(self): | |||
| CollectorStatus().persist() | |||
|
|
|||
| # Intialize the collector. | |||
| agentConfig = self._set_agent_config_hostname(get_config()) | |||
| agentConfig = self._set_agent_config_hostname(get_config(parse_args=true)) | |||
There was a problem hiding this comment.
A couple things here. First, it should be True and not true. Second, won't this still parse the args twice on Agent start? Once in main() and once here. Maybe we can pass the value for options into run()?
There was a problem hiding this comment.
Since options isn't used anywhere in the Agent run(), I decided to pass in the agentConfig from main(). I modified run so that if does not receive a config or it is None, it will run get_config(parse_args=True), but otherwise it will just pass along the config as needed.
conorbranagan
added a commit
that referenced
this pull request
Jan 10, 2013
Tracebacks on agent.py info and changed how get_config() receives options and args, fixes #329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracebacks are now available by doing -v or --verbose
Also, now in get_config(), parse_args is False by default, and allows the passing of both options and args. This way when main is called - get_parsed_args() isn't called twice.