Update ip algorithm #237
Merged
Update ip algorithm #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estringana
force-pushed
the
estringana/update-ip-extraction
branch
from
672f91c
to
d914793
Compare
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 63.87% 71.19% +7.32%
==========================================
Files 88 25 -63
Lines 5655 3222 -2433
Branches 1794 716 -1078
==========================================
- Hits 3612 2294 -1318
+ Misses 972 553 -419
+ Partials 1071 375 -696
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 64 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
estringana
force-pushed
the
estringana/update-ip-extraction
branch
from
d914793
to
66f4449
Compare
|
I will update the trace algorithm when this gets merged @Anilm3 |
Anilm3
approved these changes
Apr 6, 2023
tests/extension/extract_ip_addr.phpt
Outdated
| test('via', '2001:abcf:1f::55'); | ||
|
|
||
| test('true_client_ip', '8.8.8.8'); | ||
| test('fastly_client_ip', '7.7.7.2'); |
There was a problem hiding this comment.
Perhaps a few more tests with valid / invalid IPs as wells as IPv4 and IPv6 and ports. For all three new headers...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update ip detection algorithm to pick the most priority header. Before if there were ips in multiple headers, it would report all of them
Motivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist