Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add pull request links in CHANGELOG #1753

Merged
merged 1 commit into from
Mar 29, 2024
Merged

doc: Add pull request links in CHANGELOG #1753

merged 1 commit into from
Mar 29, 2024

Conversation

fuzzybinary
Copy link
Member

What and why?

Add PR links for the error mapping changes made.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@fuzzybinary
doc: Add pull request links in CHANGELOG
322d5de 
Add PR links for the error mapping changes made.
@fuzzybinary fuzzybinary requested review from a team as code owners March 29, 2024 13:45
maxep
maxep approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@fuzzybinary fuzzybinary merged commit 723dc0d into develop Mar 29, 2024
2 checks passed
@fuzzybinary fuzzybinary deleted the jward/changelog-changes branch March 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzybinary @maxep