🔭 [SDS-247] Add metric regarding multi-pass v0 #40
Conversation
sds/src/scanner/metrics.rs
Outdated
| impl Default for Metrics { | ||
| fn default() -> Self { | ||
| Metrics::new(&NO_LABEL) | ||
| } |
There was a problem hiding this comment.
I'm not sure it's needed, maybe we don't need a default here.
There was a problem hiding this comment.
sds/src/scanner/metrics.rs
Outdated
| Metrics { | ||
| false_positive_excluded_attributes: counter!( | ||
| "false_positive.excluded_attributes", | ||
| labels.clone_with_labels(Labels::new(&[(TYPE, "excluded_attributes".to_string())])) |
There was a problem hiding this comment.
Minor, no need to add the type:excluded_attributes tag here as the same of the metric is already pretty explicit.
Also, I believe we can find a name a bit more explicit for this metric. What do you think of false_positive.multipass.excluded_match ?
There was a problem hiding this comment.
sds/src/scanner/mod.rs
Outdated
| @@ -88,6 +91,7 @@ impl Scanner { | |||
| rules: rules.clone(), | |||
| scoped_ruleset, | |||
| cache_pool: CachePool::new(rules), | |||
| metrics: Metrics::new(&scanner_labels), | |||
There was a problem hiding this comment.
logs.sds.false_positives.v0 is tagged by scrubbing_rule_name. With the current implementation, we will lose this tag. Would it be possible to keep this tag?
There was a problem hiding this comment.
I re-implemented this to include the tags of the rule: Create metric for each compiled rule
artslidd
force-pushed
the
artslidd/sds-247-add-obsv
branch
from
99043f2
to
5b63ed6
Compare
sds/src/scanner/mod.rs
Outdated
| assert_eq!(snapshot.len(), 3); | ||
|
|
||
| let metric_name = "false_positive.multipass.excluded_match"; | ||
| let metric_pos = snapshot |
There was a problem hiding this comment.
I would recommend converting the snapshot into a HashMap so you can directly lookup by key.
There was a problem hiding this comment.
Yes, didn't see it was possible, it will be much better indeed!
Description
Add a metric to measure the multi pass scanning v0 false positives generated.