add missing overloads to TraceID's operator== and operator!= #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cataphract
pushed a commit
to cataphract/dd-trace-cpp
that referenced
this pull request
Mar 28, 2024
This revision removes the dependence on [dd-opentracing-cpp][1] and on [opentracing-cpp][2]. Instead, the newer [dd-trace-cpp][3] is used for tracing.
In addition to changing the implementation detail that is the underlying tracing library, I also changed how the module is configured. Previously, users could specify tracer configuration via a `datadog` block directive containing JSON, e.g.
```nginx
http {
datadog {
"agent_url": "http://dd-agent:8126",
"sample_rate": 0.1,
"propagation_style_extract": ["B3", "Datadog"]
}
...
}
```
Now, the most consequential configuration options (agent URL, propagation styles, and sample rate) have their own configuration directives, and the `datadog { ... }` block directive has been removed. The example above now looks like:
```nginx
http {
datadog_agent_url http://dd-agent:8126;
datadog_sample_rate 0.1;
datadog_propagation_styles B3 Datadog;
...
}
```
See the changes to `doc/API.md` for a description of the new configuration directives. The `datadog_sample_rate` directive is particularly sophisticated and is designed to obviate the need for specifying sampling rules.
Environment variables are still supported.
Another change is that `datadog_*` directives are no longer allowed in `if` contexts. The directive that I guessed was most likely to be used in an `if` context, `datadog_tag`, does not work reliably in `if` contexts. I tested it and decided it was not worth making work. This we might need to revisit per user feedback.
[1]: https://github.com/DataDog/dd-opentracing-cpp
[2]: https://github.com/opentracing/opentracing-cpp
[3]: https://github.com/DataDog/dd-trace-cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace_id == some_intwas defined, but notsome_int == trace_id.