Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gin to latest 1.8.x ? #1645

Closed
denouche opened this issue Jan 2, 2023 · 3 comments · Fixed by #2171
Closed

Update Gin to latest 1.8.x ? #1645

denouche opened this issue Jan 2, 2023 · 3 comments · Fixed by #2171
Labels
apm:ecosystem contrib/* related feature requests or bugs question

Comments

@denouche
Copy link

denouche commented Jan 2, 2023

Hello,
I wanted to update Gin in my project dependencies to the latest 1.8.2 as this version fix an important vulnerability.
But when I upgrade gin to 1.8.2 I loose the datadog APM, I don't know exactly why.
I wonder if the fact dd-trace-go depends on 1.7.x of Gin, and that Gin context management has been broken in 1.8.x can be the source of my problem.
Is that possible to upgrade the gin dependency of dd-trace-go to 1.8.x please?
Thanks

@denouche denouche added the enhancement quick change/addition that does not need full team approval label Jan 2, 2023
@katiehockman katiehockman added apm:ecosystem contrib/* related feature requests or bugs and removed enhancement quick change/addition that does not need full team approval labels Jan 11, 2023
@knusbaum
Copy link
Contributor

I loose the datadog APM, I don't know exactly why.

Can you provide details on what exactly happens? Does the code fail to compile? Do your traces disappear, etc.

@arpitparmar5739
Copy link

arpitparmar5739 commented Feb 15, 2023

I am trying to update my dependencies using go get -u .../. but getting following error:

go: github.com/DataDog/go-tuf@v0.5.0: parsing go.mod: module declares its path as: github.com/theupdateframework/go-tuf but was required as: github.com/DataDog/go-tuf

It is happening probably because of incompatibility of gin, dd-trace-go and go-tuf. Following are the versions I am using:

gopkg.in/DataDog/dd-trace-go.v1 v1.47.0
github.com/gin-gonic/gin v1.8.1
github.com/DataDog/go-tuf v0.3.0--fix-localmeta-fork // indirect

@Julio-Guerra
Copy link
Contributor

Julio-Guerra commented Feb 15, 2023

If what you want is upgrading gin to >= v1.8.0, then you shouldn't use go get -u like that on every package of dd-trace-go but rather do:

$ go get -u github.com/gin-gonic/gin
$ go mod tidy

To specifically update gin and its sub-dependencies only in our go.mod/go.sum files. I don't expect go-tuf to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants