-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gin to latest 1.8.x ? #1645
Comments
Can you provide details on what exactly happens? Does the code fail to compile? Do your traces disappear, etc. |
I am trying to update my dependencies using
It is happening probably because of incompatibility of gin, dd-trace-go and go-tuf. Following are the versions I am using: gopkg.in/DataDog/dd-trace-go.v1 v1.47.0 |
If what you want is upgrading gin to >= v1.8.0, then you shouldn't use go get -u like that on every package of dd-trace-go but rather do: $ go get -u github.com/gin-gonic/gin
$ go mod tidy To specifically update gin and its sub-dependencies only in our go.mod/go.sum files. I don't expect go-tuf to be an issue. |
Hello,
I wanted to update Gin in my project dependencies to the latest 1.8.2 as this version fix an important vulnerability.
But when I upgrade gin to 1.8.2 I loose the datadog APM, I don't know exactly why.
I wonder if the fact dd-trace-go depends on 1.7.x of Gin, and that Gin context management has been broken in 1.8.x can be the source of my problem.
Is that possible to upgrade the gin dependency of dd-trace-go to 1.8.x please?
Thanks
The text was updated successfully, but these errors were encountered: