contrib/net/http: fix status reporting for empty replies #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no data is written, in an HTTP handler, our wrapped response writer fails to capture a status code, resulting it the StatusCode tag being missing from the span. We should detect this situation and record a 200 OK, which is the default code for an empty response.
gbbr
reviewed
Jan 26, 2022
| @@ -81,6 +81,6 @@ func wrapResponseWriter(w http.ResponseWriter, span ddtrace.Span) http.ResponseW | |||
| w = mw | |||
| } | |||
|
|
|||
| return w | |||
| return w, mw | |||
There was a problem hiding this comment.
Why not simply change the type of the return value from http.ResponseWriter to *responseWriter? It should still work, because it still implements http.ResponseWriter. This way you're just returning the same thing twice under different types. Or, have I missed something?
There was a problem hiding this comment.
Unfortunately, w is a http.ResponseWriter since we're inventing them on the fly by combining things into unnamed struct types. At the end, w is not a *responseWriter, but a struct containing one, so we have to return the *responseWriter independently. I agree it's kind of ugly, but I'm not sure a better way without more major refactoring.
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
…ataDog/dd-trace-go into knusbaum/improve-http-status-reporting
Julio-Guerra
approved these changes
Apr 5, 2022
ajgajg1134
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no data is written, in an HTTP handler, our wrapped response writer
fails to capture a status code, resulting it the StatusCode tag being
missing from the span. We should detect this situation and record a 200 OK,
which is the default code for an empty response.