-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/net/http: fix status reporting for empty replies #1140
Merged
Commits on Jan 21, 2022
-
contrib/net/http: fix status reporting for empty replies
When no data is written, in an HTTP handler, our wrapped response writer fails to capture a status code, resulting it the StatusCode tag being missing from the span. We should detect this situation and record a 200 OK, which is the default code for an empty response.
Configuration menu - View commit details
-
Copy full SHA for 5a8d2bd - Browse repository at this point
Copy the full SHA 5a8d2bdView commit details
Commits on Jan 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 53604ce - Browse repository at this point
Copy the full SHA 53604ceView commit details
Commits on Jan 26, 2022
-
Update contrib/net/http/trace_test.go
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d9530e - Browse repository at this point
Copy the full SHA 2d9530eView commit details
Commits on Mar 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5e96edc - Browse repository at this point
Copy the full SHA 5e96edcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71163ad - Browse repository at this point
Copy the full SHA 71163adView commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cb1d0df - Browse repository at this point
Copy the full SHA cb1d0dfView commit details -
Merge branch 'knusbaum/improve-http-status-reporting' of github.com:D…
…ataDog/dd-trace-go into knusbaum/improve-http-status-reporting
Configuration menu - View commit details
-
Copy full SHA for 290b470 - Browse repository at this point
Copy the full SHA 290b470View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e0e660 - Browse repository at this point
Copy the full SHA 6e0e660View commit details
Commits on Apr 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8ef4b20 - Browse repository at this point
Copy the full SHA 8ef4b20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5097b1f - Browse repository at this point
Copy the full SHA 5097b1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38d9c57 - Browse repository at this point
Copy the full SHA 38d9c57View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.