New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/jackc/pgx.v5: add pgx support #2410
Conversation
Add support for utilizing the integrated tracing functionality in github.com/jackc/pgx/v5, rather than having to go through the database/sql interface.
Also interested to follow this PR's progress. We use pgx and DataDog and would love to use both together. Thanks @renanferr for moving this along, much appreciated! |
Feel free to comment any suggestions, I was working on fixing the tests first. |
@ajgajg1134 Can we get some reviewers assigned? Also do you have a timeline of when this feature might get added? We are currently implementing a workaround on our side but would be great to have this built in already 🙏 |
@darccio Thank you for the quick reply! 🚀 That's awesome! Let us know if there is anything we can help with to move this one along 👍 |
…-go into renanferr/pgx-support
Do you have any milestone for v2 release? |
@Apologiz As previously stated, we are working on it but we don't have a fixed release date. |
@renanferr Thanks for your work fixing the tests, the help is really appreciated! I've been testing the PR and it LGTM! It can be merged as soon it gets an approval from the folks from @DataDog/apm-go. Thanks everyone for your patience! |
This contrib will be released as part of v1.61.0 in the next weeks. |
@darccio Wow! It's great to hear that! Why can't you guys realease it at v1.60.2? 😢 |
@oGabrielArruda Patch versions don't include new features. Don't worry, the release process for v1.61.0 starts next Monday 😁 |
The timing on this is impeccable; I'm looking forward to next week's release, thanks all! |
@samsullivan Happy to hear that. Just to keep expectations aligned, it starts next week but it usually takes a few days to complete our QA. We can't give an exact release date, but it'll happen during the next weeks. Also, updating about v2: we are still working on it and it'll happen during this quarter. |
What does this PR do?
Continuation of #2236
Fixes #697
Motivation
There wasn't any activity in the mentioned PR for the last weeks so I figured I could fix the tests myself and continue this on another PR.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!