Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/jackc/pgx.v5: add pgx support #2410

Merged
merged 37 commits into from Feb 7, 2024

Conversation

renanferr
Copy link
Contributor

@renanferr renanferr commented Dec 4, 2023

What does this PR do?

Continuation of #2236

Fixes #697

Motivation

There wasn't any activity in the mentioned PR for the last weeks so I figured I could fix the tests myself and continue this on another PR.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@samcfinan
Copy link

Also interested to follow this PR's progress. We use pgx and DataDog and would love to use both together.

Thanks @renanferr for moving this along, much appreciated!

@renanferr
Copy link
Contributor Author

Feel free to comment any suggestions, I was working on fixing the tests first.

@renanferr renanferr marked this pull request as ready for review December 21, 2023 19:17
@renanferr renanferr requested a review from a team December 21, 2023 19:17
@renanferr renanferr requested a review from a team as a code owner December 21, 2023 19:17
@ajgajg1134 ajgajg1134 added the apm:ecosystem contrib/* related feature requests or bugs label Dec 21, 2023
@david-azevedo
Copy link

@ajgajg1134 Can we get some reviewers assigned? Also do you have a timeline of when this feature might get added? We are currently implementing a workaround on our side but would be great to have this built in already 🙏

@david-azevedo
Copy link

@darccio Thank you for the quick reply! 🚀

That's awesome! Let us know if there is anything we can help with to move this one along 👍

@felixge felixge removed the request for review from a team January 10, 2024 08:50
@Apologiz
Copy link

@david-azevedo We are working in our next major release, dd-trace-go v2. We'll discuss internally to include this directly in v2 or in one of the last v1 releases. There is not an exact deadline for v2, but it's going to happen during 2024 Q1.

Do you have any milestone for v2 release?

@darccio
Copy link
Contributor

darccio commented Jan 16, 2024

@Apologiz As previously stated, we are working on it but we don't have a fixed release date.

@rarguelloF
Copy link
Contributor

@renanferr Thanks for your work fixing the tests, the help is really appreciated!
I went ahead and introduced some changes, adding some missing tags and some other minor refactors.

I've been testing the PR and it LGTM! It can be merged as soon it gets an approval from the folks from @DataDog/apm-go. Thanks everyone for your patience!

@darccio darccio merged commit f0c338a into DataDog:main Feb 7, 2024
100 checks passed
@darccio
Copy link
Contributor

darccio commented Feb 8, 2024

This contrib will be released as part of v1.61.0 in the next weeks.

@oGabrielArruda
Copy link

@darccio Wow! It's great to hear that!

Why can't you guys realease it at v1.60.2? 😢
It would be great to use this functionality as soon as possible

@darccio
Copy link
Contributor

darccio commented Feb 8, 2024

@oGabrielArruda Patch versions don't include new features. Don't worry, the release process for v1.61.0 starts next Monday 😁

@samsullivan
Copy link
Contributor

The timing on this is impeccable; I'm looking forward to next week's release, thanks all!

@darccio
Copy link
Contributor

darccio commented Feb 9, 2024

@samsullivan Happy to hear that. Just to keep expectations aligned, it starts next week but it usually takes a few days to complete our QA. We can't give an exact release date, but it'll happen during the next weeks.

Also, updating about v2: we are still working on it and it'll happen during this quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: integrate with github.com/jackc/pgx