Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: Reduce go.mod/go.sum related pings #2484

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

felixge
Copy link
Member

@felixge felixge commented Jan 8, 2024

What does this PR do?

  • Remove @DataDog/dd-trace-go-guild as the CODEOWNER for go.mod and go.sum.

Motivation

Most PRs that touch go.mod or go.sum are only relevant for the team working on it. For example: #2410

This change will avoid the @DataDog/dd-trace-go-guild team to be added to such PRs by default and allow anybody with review permissions on dd-trace-go to approve the PR.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2024

Benchmarks

Benchmark execution time: 2024-01-08 12:49:31

Comparing candidate commit b9ec302 in PR branch felix.geisendoerfer/PROF-8863-reduce-gomod-pings with baseline commit 1a89fe9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@felixge felixge marked this pull request as ready for review January 8, 2024 12:33
@felixge felixge requested a review from a team as a code owner January 8, 2024 12:33
@felixge felixge requested a review from darccio January 8, 2024 12:35
@felixge
Copy link
Member Author

felixge commented Jan 8, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 8, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 9m)

you can cancel this operation by commenting your pull request with /merge -c!

@felixge felixge enabled auto-merge (squash) January 8, 2024 13:19
@DataDog DataDog deleted a comment from dd-devflow bot Jan 8, 2024
@felixge felixge merged commit 7c31025 into main Jan 8, 2024
154 checks passed
@felixge felixge deleted the felix.geisendoerfer/PROF-8863-reduce-gomod-pings branch January 8, 2024 13:26
@nsrip-dd
Copy link
Contributor

nsrip-dd commented Jan 8, 2024

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants