WIP: contrib/jackc/pgx.v5: add support for pgx #2236
Conversation
Add support for utilizing the integrated tracing functionality in github.com/jackc/pgx/v5, rather than having to go through the database/sql interface.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| package pgx | ||
|
|
||
| import ( | ||
| "context" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard,prefix(gopkg.in/DataDog/dd-trace-go.v1),default (gci)
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard,prefix(gopkg.in/DataDog/dd-trace-go.v1),default (gci)
| os.Exit(m.Run()) | ||
| } | ||
|
|
||
| func assertCommonTags(t *testing.T, s mocktracer.Span, qType string) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
| assert.Equal(t, "parent", s2.Tag(ext.ResourceName)) | ||
| } | ||
|
|
||
| func TestTraceBatch(t *testing.T) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
What's left to get this over the line? Would love support for pgx. |
|
Is there any other remained process? |
|
this is missing several features for parity with database/sql:
|
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been open for 30 days with no activity. |
What does this PR do?
Continuation of #2160
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!