Add enabledProducts tag to all spans (APM / DSM / DJM) #6967

kr-igor · 2024-04-29T19:31:21Z

What Does This Do

This PR adds product tags for DSM and DJM.

Motivation

Because customers may use APM / DJM / DSM in any configuration we need an easy way of distinguishing spans produced by the tracer (to avoid double charging in some cases).

Additional Notes

Jira

richardstartin

There is already a pattern of adding product enablement tags to root spans for appsec and profiling, I suggest following this pattern. Let's discuss offline.

pr-commenter · 2024-04-29T20:29:55Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	kr-igor/enabled-products-tag
git_commit_date	1714499775	1714513223
git_commit_sha	`16c56bf`	`0d3e239`
release_version	1.34.0-SNAPSHOT~16c56bf74f	1.34.0-SNAPSHOT~0d3e23913a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714515851	1714515851
ci_job_id	501417404	501417404
ci_pipeline_id	33313048	33313048
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077211
Total [baseline] (10.38 s) : 0, 10380472
Agent [candidate] (1.076 s) : 0, 1075630
Total [candidate] (10.377 s) : 0, 10376729
section appsec
Agent [baseline] (1.193 s) : 0, 1192825
Total [baseline] (10.467 s) : 0, 10466817
Agent [candidate] (1.194 s) : 0, 1193684
Total [candidate] (10.502 s) : 0, 10501575
section iast
Agent [baseline] (1.201 s) : 0, 1201281
Total [baseline] (10.709 s) : 0, 10708878
Agent [candidate] (1.2 s) : 0, 1200290
Total [candidate] (10.727 s) : 0, 10726594
section profiling
Agent [baseline] (1.267 s) : 0, 1266536
Total [baseline] (10.6 s) : 0, 10600071
Agent [candidate] (1.27 s) : 0, 1269617
Total [candidate] (10.624 s) : 0, 10623500

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.077 s	-
Agent	appsec	1.193 s	115.614 ms (10.7%)
Agent	iast	1.201 s	124.07 ms (11.5%)
Agent	profiling	1.267 s	189.325 ms (17.6%)
Total	tracing	10.38 s	-
Total	appsec	10.467 s	86.344 ms (0.8%)
Total	iast	10.709 s	328.406 ms (3.2%)
Total	profiling	10.6 s	219.599 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	appsec	1.194 s	118.055 ms (11.0%)
Agent	iast	1.2 s	124.66 ms (11.6%)
Agent	profiling	1.27 s	193.987 ms (18.0%)
Total	tracing	10.377 s	-
Total	appsec	10.502 s	124.846 ms (1.2%)
Total	iast	10.727 s	349.865 ms (3.4%)
Total	profiling	10.624 s	246.771 ms (2.4%)

gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.358 ms) : 0, 675358
BytebuddyAgent [candidate] (673.853 ms) : 0, 673853
GlobalTracer [baseline] (309.726 ms) : 0, 309726
GlobalTracer [candidate] (309.743 ms) : 0, 309743
AppSec [baseline] (49.448 ms) : 0, 49448
AppSec [candidate] (49.535 ms) : 0, 49535
Remote Config [baseline] (654.284 µs) : 0, 654
Remote Config [candidate] (649.26 µs) : 0, 649
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.476 ms) : 0, 7476
section appsec
BytebuddyAgent [baseline] (697.836 ms) : 0, 697836
BytebuddyAgent [candidate] (698.036 ms) : 0, 698036
GlobalTracer [baseline] (291.612 ms) : 0, 291612
GlobalTracer [candidate] (292.617 ms) : 0, 292617
AppSec [baseline] (149.195 ms) : 0, 149195
AppSec [candidate] (149.319 ms) : 0, 149319
Remote Config [baseline] (619.476 µs) : 0, 619
Remote Config [candidate] (621.11 µs) : 0, 621
Telemetry [baseline] (9.424 ms) : 0, 9424
Telemetry [candidate] (8.831 ms) : 0, 8831
IAST [baseline] (19.219 ms) : 0, 19219
IAST [candidate] (19.387 ms) : 0, 19387
section iast
BytebuddyAgent [baseline] (795.337 ms) : 0, 795337
BytebuddyAgent [candidate] (794.761 ms) : 0, 794761
GlobalTracer [baseline] (288.694 ms) : 0, 288694
GlobalTracer [candidate] (288.507 ms) : 0, 288507
AppSec [baseline] (49.064 ms) : 0, 49064
AppSec [candidate] (50.065 ms) : 0, 50065
Remote Config [baseline] (2.055 ms) : 0, 2055
Remote Config [candidate] (1.4 ms) : 0, 1400
Telemetry [baseline] (6.666 ms) : 0, 6666
Telemetry [candidate] (6.688 ms) : 0, 6688
IAST [baseline] (24.977 ms) : 0, 24977
IAST [candidate] (24.417 ms) : 0, 24417
section profiling
BytebuddyAgent [baseline] (676.685 ms) : 0, 676685
BytebuddyAgent [candidate] (678.58 ms) : 0, 678580
GlobalTracer [baseline] (379.805 ms) : 0, 379805
GlobalTracer [candidate] (380.342 ms) : 0, 380342
AppSec [baseline] (50.144 ms) : 0, 50144
AppSec [candidate] (50.126 ms) : 0, 50126
Remote Config [baseline] (697.851 µs) : 0, 698
Remote Config [candidate] (715.103 µs) : 0, 715
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.468 ms) : 0, 7468
ProfilingAgent [baseline] (95.46 ms) : 0, 95460
ProfilingAgent [candidate] (95.849 ms) : 0, 95849
Profiling [baseline] (95.483 ms) : 0, 95483
Profiling [candidate] (95.873 ms) : 0, 95873

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076073
Total [baseline] (8.526 s) : 0, 8525601
Agent [candidate] (1.076 s) : 0, 1075607
Total [candidate] (8.563 s) : 0, 8563251
section iast
Agent [baseline] (1.198 s) : 0, 1197721
Total [baseline] (8.999 s) : 0, 8998552
Agent [candidate] (1.201 s) : 0, 1200612
Total [candidate] (8.999 s) : 0, 8999027
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1200134
Total [baseline] (8.98 s) : 0, 8980429
Agent [candidate] (1.203 s) : 0, 1202720
Total [candidate] (8.957 s) : 0, 8957487
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197051
Total [baseline] (8.989 s) : 0, 8989028
Agent [candidate] (1.198 s) : 0, 1197842
Total [candidate] (8.986 s) : 0, 8985513

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	iast	1.198 s	121.648 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.2 s	124.061 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.197 s	120.978 ms (11.2%)
Total	tracing	8.526 s	-
Total	iast	8.999 s	472.95 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	8.98 s	454.828 ms (5.3%)
Total	iast_TELEMETRY_OFF	8.989 s	463.427 ms (5.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	iast	1.201 s	125.006 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.203 s	127.113 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.198 s	122.236 ms (11.4%)
Total	tracing	8.563 s	-
Total	iast	8.999 s	435.776 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	8.957 s	394.236 ms (4.6%)
Total	iast_TELEMETRY_OFF	8.986 s	422.262 ms (4.9%)

gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.17 ms) : 0, 674170
BytebuddyAgent [candidate] (673.822 ms) : 0, 673822
GlobalTracer [baseline] (309.846 ms) : 0, 309846
GlobalTracer [candidate] (309.92 ms) : 0, 309920
AppSec [baseline] (49.46 ms) : 0, 49460
AppSec [candidate] (49.313 ms) : 0, 49313
Remote Config [baseline] (654.085 µs) : 0, 654
Remote Config [candidate] (659.687 µs) : 0, 660
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.564 ms) : 0, 7564
section iast
BytebuddyAgent [baseline] (793.674 ms) : 0, 793674
BytebuddyAgent [candidate] (795.761 ms) : 0, 795761
GlobalTracer [baseline] (287.739 ms) : 0, 287739
GlobalTracer [candidate] (288.129 ms) : 0, 288129
AppSec [baseline] (51.694 ms) : 0, 51694
AppSec [candidate] (51.171 ms) : 0, 51171
Remote Config [baseline] (581.185 µs) : 0, 581
Remote Config [candidate] (583.107 µs) : 0, 583
Telemetry [baseline] (6.627 ms) : 0, 6627
Telemetry [candidate] (7.39 ms) : 0, 7390
IAST [baseline] (23.141 ms) : 0, 23141
IAST [candidate] (23.177 ms) : 0, 23177
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.769 ms) : 0, 793769
BytebuddyAgent [candidate] (796.504 ms) : 0, 796504
GlobalTracer [baseline] (288.474 ms) : 0, 288474
GlobalTracer [candidate] (288.914 ms) : 0, 288914
AppSec [baseline] (49.281 ms) : 0, 49281
AppSec [candidate] (50.675 ms) : 0, 50675
Remote Config [baseline] (1.397 ms) : 0, 1397
Remote Config [candidate] (1.296 ms) : 0, 1296
Telemetry [baseline] (6.65 ms) : 0, 6650
Telemetry [candidate] (6.644 ms) : 0, 6644
IAST [baseline] (26.093 ms) : 0, 26093
IAST [candidate] (24.158 ms) : 0, 24158
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.476 ms) : 0, 792476
BytebuddyAgent [candidate] (793.217 ms) : 0, 793217
GlobalTracer [baseline] (287.855 ms) : 0, 287855
GlobalTracer [candidate] (288.81 ms) : 0, 288810
AppSec [baseline] (51.429 ms) : 0, 51429
AppSec [candidate] (51.543 ms) : 0, 51543
Remote Config [baseline] (572.012 µs) : 0, 572
Remote Config [candidate] (581.379 µs) : 0, 581
Telemetry [baseline] (6.579 ms) : 0, 6579
Telemetry [candidate] (6.589 ms) : 0, 6589
IAST [baseline] (23.738 ms) : 0, 23738
IAST [candidate] (22.752 ms) : 0, 22752

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-04-30T21:55:02	2024-04-30T22:01:51
git_branch	master	kr-igor/enabled-products-tag
git_commit_date	1714499775	1714513223
git_commit_sha	`16c56bf`	`0d3e239`
release_version	1.34.0-SNAPSHOT~16c56bf74f	1.34.0-SNAPSHOT~0d3e23913a
start_time	2024-04-30T21:54:49	2024-04-30T22:01:38

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714514856	1714514856
ci_job_id	501417405	501417405
ci_pipeline_id	33313048	33313048
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.724 ms) : 1699, 1749
.   : milestone, 1724,
appsec_no_iast (1.741 ms) : 1717, 1765
.   : milestone, 1741,
iast (1.498 ms) : 1475, 1521
.   : milestone, 1498,
profiling (1.497 ms) : 1472, 1522
.   : milestone, 1497,
tracing (1.463 ms) : 1438, 1489
.   : milestone, 1463,
section candidate
no_agent (1.358 ms) : 1339, 1378
.   : milestone, 1358,
appsec (1.729 ms) : 1704, 1753
.   : milestone, 1729,
appsec_no_iast (1.708 ms) : 1684, 1733
.   : milestone, 1708,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.501 ms) : 1476, 1526
.   : milestone, 1501,
tracing (1.495 ms) : 1470, 1520
.   : milestone, 1495,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.335 ms, 1.374 ms]	-
appsec	1.724 ms [1.699 ms, 1.749 ms]	369.77 µs (27.3%)
appsec_no_iast	1.741 ms [1.717 ms, 1.765 ms]	386.498 µs (28.5%)
iast	1.498 ms [1.475 ms, 1.521 ms]	143.757 µs (10.6%)
profiling	1.497 ms [1.472 ms, 1.522 ms]	143.229 µs (10.6%)
tracing	1.463 ms [1.438 ms, 1.489 ms]	109.057 µs (8.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.378 ms]	-
appsec	1.729 ms [1.704 ms, 1.753 ms]	370.361 µs (27.3%)
appsec_no_iast	1.708 ms [1.684 ms, 1.733 ms]	350.1 µs (25.8%)
iast	1.477 ms [1.454 ms, 1.5 ms]	118.696 µs (8.7%)
profiling	1.501 ms [1.476 ms, 1.526 ms]	142.642 µs (10.5%)
tracing	1.495 ms [1.47 ms, 1.52 ms]	136.753 µs (10.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.944 µs) : 355, 395
.   : milestone, 375,
iast (479.047 µs) : 458, 500
.   : milestone, 479,
iast_FULL (541.215 µs) : 521, 562
.   : milestone, 541,
iast_GLOBAL (495.957 µs) : 476, 516
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (474.62 µs) : 453, 496
.   : milestone, 475,
iast_INACTIVE (454.827 µs) : 434, 475
.   : milestone, 455,
iast_TELEMETRY_OFF (470.716 µs) : 450, 492
.   : milestone, 471,
tracing (449.587 µs) : 429, 470
.   : milestone, 450,
section candidate
no_agent (373.001 µs) : 353, 393
.   : milestone, 373,
iast (475.852 µs) : 455, 496
.   : milestone, 476,
iast_FULL (539.062 µs) : 518, 560
.   : milestone, 539,
iast_GLOBAL (505.377 µs) : 483, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (481.158 µs) : 459, 503
.   : milestone, 481,
iast_INACTIVE (455.189 µs) : 433, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (473.415 µs) : 452, 495
.   : milestone, 473,
tracing (452.436 µs) : 431, 474
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.944 µs [355.329 µs, 394.559 µs]	-
iast	479.047 µs [458.44 µs, 499.654 µs]	104.104 µs (27.8%)
iast_FULL	541.215 µs [520.592 µs, 561.839 µs]	166.272 µs (44.3%)
iast_GLOBAL	495.957 µs [475.564 µs, 516.35 µs]	121.013 µs (32.3%)
iast_HARDCODED_SECRET_DISABLED	474.62 µs [453.105 µs, 496.134 µs]	99.676 µs (26.6%)
iast_INACTIVE	454.827 µs [434.366 µs, 475.289 µs]	79.884 µs (21.3%)
iast_TELEMETRY_OFF	470.716 µs [449.72 µs, 491.713 µs]	95.773 µs (25.5%)
tracing	449.587 µs [428.764 µs, 470.409 µs]	74.643 µs (19.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.001 µs [352.982 µs, 393.02 µs]	-
iast	475.852 µs [455.419 µs, 496.285 µs]	102.851 µs (27.6%)
iast_FULL	539.062 µs [518.114 µs, 560.011 µs]	166.061 µs (44.5%)
iast_GLOBAL	505.377 µs [483.462 µs, 527.292 µs]	132.376 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED	481.158 µs [459.033 µs, 503.283 µs]	108.157 µs (29.0%)
iast_INACTIVE	455.189 µs [433.373 µs, 477.004 µs]	82.187 µs (22.0%)
iast_TELEMETRY_OFF	473.415 µs [451.758 µs, 495.071 µs]	100.413 µs (26.9%)
tracing	452.436 µs [430.554 µs, 474.318 µs]	79.435 µs (21.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	kr-igor/enabled-products-tag
git_commit_date	1714499775	1714513223
git_commit_sha	`16c56bf`	`0d3e239`
release_version	1.34.0-SNAPSHOT~16c56bf74f	1.34.0-SNAPSHOT~0d3e23913a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1714515375	1714515375
ci_job_id	501417406	501417406
ci_pipeline_id	33313048	33313048
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1479
.   : milestone, 1468,
appsec (2.205 ms) : 2172, 2238
.   : milestone, 2205,
iast (1.894 ms) : 1859, 1930
.   : milestone, 1894,
iast_GLOBAL (1.927 ms) : 1892, 1963
.   : milestone, 1927,
profiling (1.854 ms) : 1820, 1888
.   : milestone, 1854,
tracing (1.839 ms) : 1806, 1871
.   : milestone, 1839,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.207 ms) : 2174, 2241
.   : milestone, 2207,
iast (1.874 ms) : 1839, 1909
.   : milestone, 1874,
iast_GLOBAL (1.93 ms) : 1894, 1966
.   : milestone, 1930,
profiling (1.847 ms) : 1814, 1881
.   : milestone, 1847,
tracing (1.832 ms) : 1800, 1864
.   : milestone, 1832,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.457 ms, 1.479 ms]	-
appsec	2.205 ms [2.172 ms, 2.238 ms]	737.012 µs (50.2%)
iast	1.894 ms [1.859 ms, 1.93 ms]	426.385 µs (29.0%)
iast_GLOBAL	1.927 ms [1.892 ms, 1.963 ms]	459.317 µs (31.3%)
profiling	1.854 ms [1.82 ms, 1.888 ms]	386.249 µs (26.3%)
tracing	1.839 ms [1.806 ms, 1.871 ms]	370.501 µs (25.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.451 ms, 1.474 ms]	-
appsec	2.207 ms [2.174 ms, 2.241 ms]	744.724 µs (50.9%)
iast	1.874 ms [1.839 ms, 1.909 ms]	411.643 µs (28.1%)
iast_GLOBAL	1.93 ms [1.894 ms, 1.966 ms]	467.483 µs (32.0%)
profiling	1.847 ms [1.814 ms, 1.881 ms]	384.905 µs (26.3%)
tracing	1.832 ms [1.8 ms, 1.864 ms]	369.387 µs (25.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~0d3e23913a, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.1 s) : 15100000, 15100000
.   : milestone, 15100000,
appsec (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
iast (18.611 s) : 18611000, 18611000
.   : milestone, 18611000,
iast_GLOBAL (18.008 s) : 18008000, 18008000
.   : milestone, 18008000,
profiling (15.204 s) : 15204000, 15204000
.   : milestone, 15204000,
tracing (15.338 s) : 15338000, 15338000
.   : milestone, 15338000,
section candidate
no_agent (14.917 s) : 14917000, 14917000
.   : milestone, 14917000,
appsec (15.124 s) : 15124000, 15124000
.   : milestone, 15124000,
iast (18.896 s) : 18896000, 18896000
.   : milestone, 18896000,
iast_GLOBAL (17.732 s) : 17732000, 17732000
.   : milestone, 17732000,
profiling (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
tracing (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.1 s [15.1 s, 15.1 s]	-
appsec	15.111 s [15.111 s, 15.111 s]	11.0 ms (0.1%)
iast	18.611 s [18.611 s, 18.611 s]	3.511 s (23.3%)
iast_GLOBAL	18.008 s [18.008 s, 18.008 s]	2.908 s (19.3%)
profiling	15.204 s [15.204 s, 15.204 s]	104.0 ms (0.7%)
tracing	15.338 s [15.338 s, 15.338 s]	238.0 ms (1.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.917 s [14.917 s, 14.917 s]	-
appsec	15.124 s [15.124 s, 15.124 s]	207.0 ms (1.4%)
iast	18.896 s [18.896 s, 18.896 s]	3.979 s (26.7%)
iast_GLOBAL	17.732 s [17.732 s, 17.732 s]	2.815 s (18.9%)
profiling	15.187 s [15.187 s, 15.187 s]	270.0 ms (1.8%)
tracing	14.955 s [14.955 s, 14.955 s]	38.0 ms (0.3%)

gabe-ochoa · 2024-05-02T15:34:26Z

internal-api/src/main/java/datadog/trace/api/InstrumenterConfig.java

+  public boolean isDataJobsEnabled() {
+    // there's no dedicated flag to enabled DJM, it's enough to just enable
+    // spark instrumentation
+    return isIntegrationEnabled(Collections.singletonList("spark"), false);
+  }


@paul-laffon-dd, we should update this as apart of #6972. Now that this PR is merged we can do both.

kr-igor added 3 commits April 29, 2024 14:30

Add enabledProducts tag to all spans (APM / DSM / DJM)

6e9f01a

Spotless apply

8a2ddcf

Merge branch 'master' into kr-igor/enabled-products-tag

1d394bc

richardstartin requested changes Apr 29, 2024

View reviewed changes

kr-igor added 6 commits April 29, 2024 15:39

Use local root spans for DSM / DJM

6314e82

Cleanup

1b7ffde

Added product tags to asserted tags

19f53b6

Fixed one more test

0ec82ef

Fixed more tests

8c7ced5

Spotless apply

0d3e239

richardstartin approved these changes May 1, 2024

View reviewed changes

kr-igor marked this pull request as ready for review May 1, 2024 15:16

kr-igor requested a review from a team as a code owner May 1, 2024 15:16

kr-igor requested review from mcculls and ygree May 1, 2024 15:16

kr-igor merged commit b25b42f into master May 1, 2024
80 checks passed

kr-igor deleted the kr-igor/enabled-products-tag branch May 1, 2024 16:35

github-actions bot added this to the 1.34.0 milestone May 1, 2024

gabe-ochoa mentioned this pull request May 2, 2024

Add single parameter dd.data.jobs.enabled to enable DJM #6972

Merged

gabe-ochoa reviewed May 2, 2024

View reviewed changes

This was referenced May 3, 2024

Add product tags to each span if products are enabled #6990

Merged

Tag every span with the product tag if it is enabled #7011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add enabledProducts tag to all spans (APM / DSM / DJM) #6967

Add enabledProducts tag to all spans (APM / DSM / DJM) #6967

kr-igor commented Apr 29, 2024 •

edited

richardstartin left a comment

pr-commenter bot commented Apr 29, 2024 •

edited

gabe-ochoa May 2, 2024

Add enabledProducts tag to all spans (APM / DSM / DJM) #6967

Add enabledProducts tag to all spans (APM / DSM / DJM) #6967

Conversation

kr-igor commented Apr 29, 2024 • edited

What Does This Do

Motivation

Additional Notes

richardstartin left a comment

Choose a reason for hiding this comment

pr-commenter bot commented Apr 29, 2024 • edited

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

gabe-ochoa May 2, 2024

Choose a reason for hiding this comment

kr-igor commented Apr 29, 2024 •

edited

pr-commenter bot commented Apr 29, 2024 •

edited